Add amazon EC2 Provider to IaaS #111
Conversation
gtsalles
requested review from
avelino,
crgimenes,
kemelzaidan,
marioidival,
cassiobotaro,
perylemke,
felipeweb and
EltonSouza
iaas/amazonec2/amazonec2.go
Outdated
| driverOpts.Values["swarm-strategy"] = "spread" | ||
| driverOpts.Values["swarm-discovery"] = "" | ||
| driverOpts.Values["swarm-master"] = false | ||
| driver.SetConfigFromFlags(&driverOpts) |
There was a problem hiding this comment.
Error return value of driver.SetConfigFromFlags is not checked
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
=========================================
- Coverage 53.55% 51.9% -1.65%
=========================================
Files 5 6 +1
Lines 450 524 +74
=========================================
+ Hits 241 272 +31
- Misses 185 228 +43
Partials 24 24
Continue to review full report at Codecov.
|
| driverOpts.Values[f.String()] = false | ||
| } | ||
| } | ||
| // TODO: receive this configs to remove hard coded values |
There was a problem hiding this comment.
It's not the ideal scenario to have this configurations hard coded, instead, we should receive them as parameters, or (my preferred option) get the default values just like the docker-machine binary uses when creating a machine via cli, but honestly, I wasn't able to replicate this behavior.
| driverOpts.Values[f.String()] = false | ||
| } | ||
| } | ||
| // TODO: receive this configs to remove hard coded values |
There was a problem hiding this comment.
you can implement functional option pattern so this values can be override easier. An exemple https://github.com/nuveo/storing/blob/master/awss3/awss3.go
There was a problem hiding this comment.
I don't think I need to override this values, the better approach is just replicate the same default values that docker-machine uses. Right now, they are hard coded, the ideal would be retrieve them somehow, maybe something like the driver.GetCreateFlags() method, but retrieving the swarm values.
This PR adds support for usage of EC2 from AWS to gofn, simply instantiating a new provider with secret and access keys.
Example to verify execution:
https://github.com/gofn/gofn/tree/improvements/aws_ec2/examples/amazonec2
ref #54