rework tests from gocheck to stdlib testing #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are probably things that I missed here. I'm sending this PR for preliminary review. It's fairly big, and it's going to need some eyes on it before a potential merge. |
|
Ugh. I completely forgot Go < 1.7 doesn't have subtests. Travis isn't happy. What should we do? I can get rid of all the subtests if we need to. |
|
@acln0 I wouldn't be against dropping the test runners for the older Go versions within the context of this PR. Outside of this PR, we should have the discussion as an organization as to whether our support of Go runtime versions differs from the authors. |
|
Filed #18 for discussion. |
Closed
theckman
added a commit
that referenced
this pull request
Jul 16, 2018
In preparation for executing on #15 (already opened in #17) we need to disable testing against older versions of the Go toolchain. There are a few reasons for this, the largest being they don't support subtests. These versions, including Go 1.7 and 1.8, are EOL by the Go authors so there's also lack of upstream support for these toolchains. This was discussed a bit in #18 and on [Slack](https://gophers.slack.com/archives/CBP4N9BEU/p1531704009000014). Fixes #18 Signed-off-by: Tim Heckman <t@heckman.io>
theckman
added a commit
that referenced
this pull request
Jul 16, 2018
In preparation for executing on #15 (already opened in #17) we need to disable testing against older versions of the Go toolchain. There are a few reasons for this, the largest being they don't support subtests. These versions, including Go 1.7 and 1.8, are EOL by the Go authors so there's also lack of upstream support for these toolchains. This was discussed a bit in #18 and on [Slack](https://gophers.slack.com/archives/CBP4N9BEU/p1531704009000014). Fixes #18 Signed-off-by: Tim Heckman <t@heckman.io>
theckman
added a commit
that referenced
this pull request
Jul 16, 2018
In preparation for executing on #15 (already opened in #17) we need to disable testing against older versions of the Go toolchain. There are a few reasons for this, the largest being they don't support subtests. These versions, including Go 1.7 and 1.8, are EOL by the Go authors so there's also lack of upstream support for these toolchains. This was discussed a bit in #18 and on [Slack](https://gophers.slack.com/archives/CBP4N9BEU/p1531704009000014). Fixes #18 Signed-off-by: Tim Heckman <t@heckman.io>
theckman
added a commit
that referenced
this pull request
Jul 16, 2018
In preparation for executing on #15 (already opened in #17) we need to disable testing against older versions of the Go toolchain. There are a few reasons for this, the largest being they don't support subtests. These versions, including Go 1.7 and 1.8, are EOL by the Go authors so there's also lack of upstream support for these toolchains. This was discussed a bit in #18 and on [Slack](https://gophers.slack.com/archives/CBP4N9BEU/p1531704009000014). Fixes #18 Signed-off-by: Tim Heckman <t@heckman.io>
theckman
added a commit
that referenced
this pull request
Jul 16, 2018
In preparation for executing on #15 (already opened in #17) we need to disable testing against older versions of the Go toolchain. There are a few reasons for this, the largest being they don't support subtests. These versions, including Go 1.7 and 1.8, are EOL by the Go authors so there's also lack of upstream support for these toolchains. This was discussed a bit in #18 and on [Slack](https://gophers.slack.com/archives/CBP4N9BEU/p1531704009000014). Fixes #18 Signed-off-by: Tim Heckman <t@heckman.io>
|
@acln0 can you rebase this branch against |
Use the standard library testing package instead of gocheck. Switch from multiple assertions to table-driven tests where appropriate. Update fuzz testing support: add code to generate a diverse corpus based on existing parser tests, add instructions on how to run the fuzzer, check in the existing corpus.
|
@theckman Done. @jadr2ddude Yes, that works, because the |
|
@acln0 awesome! I did a quick pass on this PR before, but let me give it a look again tonight. It'll be a few hours until I'm at home and able to give it some proper 👀. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the standard library testing package instead of gocheck. Switch
from multiple assertions to table-driven tests where appropriate.
Update fuzz testing support: add code to generate a diverse corpus
based on existing parser tests, add instructions on how to run the
fuzzer, check in the existing corpus.