-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable testing against Go 1.3 ~ 1.6 to improve tests #21
Conversation
@coveralls wat? |
README.md
Outdated
but it is not tested and support for this version is not actively maintained. | ||
This package is regularly tested against Go 1.7+, due to older versions not | ||
supporting subtests. This package may work perfectly fine with Go 1.2+, but it | ||
is not tested against and support for these older versions is not actively |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but it is not tested against and support for these [...]
This phrasing sounds a little odd to me. It may be because I'm not a native English speaker, but I had to read it a couple of times to understand the meaning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@acln0 patch applied -- how's it look now?
Gonna trigger a CI re-run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
8bf09fc
to
944b2c7
Compare
In preparation for executing on #15 (already opened in #17) we need to disable testing against older versions of the Go toolchain. There are a few reasons for this, the largest being they don't support subtests. These versions, including Go 1.7 and 1.8, are EOL by the Go authors so there's also lack of upstream support for these toolchains. This was discussed a bit in #18 and on [Slack](https://gophers.slack.com/archives/CBP4N9BEU/p1531704009000014). Fixes #18 Signed-off-by: Tim Heckman <t@heckman.io>
Disable testing against Go 1.3 ~ 1.6 to improve tests Signed-off-by: Tim Heckman <t@heckman.io>
In preparation for executing on #15 (already opened in #17) we need to disable
testing against older versions of the Go toolchain. There are a few reasons for
this, the largest being they don't support subtests. These versions, including
Go 1.7 and 1.8, are EOL by the Go authors so there's also lack of upstream
support for these toolchains.
This was discussed a bit in #18 and on Slack.
Fixes #18
Signed-off-by: Tim Heckman t@heckman.io