Disable testing against Go 1.3 ~ 1.6 to improve tests #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@coveralls wat? |
acln0
requested changes
Jul 16, 2018
README.md
Outdated
| but it is not tested and support for this version is not actively maintained. | ||
| This package is regularly tested against Go 1.7+, due to older versions not | ||
| supporting subtests. This package may work perfectly fine with Go 1.2+, but it | ||
| is not tested against and support for these older versions is not actively |
There was a problem hiding this comment.
but it is not tested against and support for these [...]
This phrasing sounds a little odd to me. It may be because I'm not a native English speaker, but I had to read it a couple of times to understand the meaning.
There was a problem hiding this comment.
@acln0 patch applied -- how's it look now?
|
Gonna trigger a CI re-run. |
theckman
force-pushed
the
no_old_go
branch
2 times, most recently
from
8bf09fc
to
944b2c7
Compare
In preparation for executing on #15 (already opened in #17) we need to disable testing against older versions of the Go toolchain. There are a few reasons for this, the largest being they don't support subtests. These versions, including Go 1.7 and 1.8, are EOL by the Go authors so there's also lack of upstream support for these toolchains. This was discussed a bit in #18 and on [Slack](https://gophers.slack.com/archives/CBP4N9BEU/p1531704009000014). Fixes #18 Signed-off-by: Tim Heckman <t@heckman.io>
theckman
added a commit
that referenced
this pull request
Jul 16, 2018
Disable testing against Go 1.3 ~ 1.6 to improve tests Signed-off-by: Tim Heckman <t@heckman.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for executing on #15 (already opened in #17) we need to disable
testing against older versions of the Go toolchain. There are a few reasons for
this, the largest being they don't support subtests. These versions, including
Go 1.7 and 1.8, are EOL by the Go authors so there's also lack of upstream
support for these toolchains.
This was discussed a bit in #18 and on Slack.
Fixes #18
Signed-off-by: Tim Heckman t@heckman.io