Export DefaultGenerator (formerly generator). #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was decided that DefaultGenerator should be exported because the pattern of NewVx() functions was similar to patterns in Go standard library packages (http.DefaultClient, flag.CommandLine, etc.). These standard library packages export their defaults. It is also impractical to write testable code using the UUID library without writing a custom Generator to wrap the NewVx() functions without this interface being exported. Signed-off-by: Jaden Weiss <jadr2ddude@gmail.com>
theckman
approved these changes
Jul 14, 2018
theckman
added a commit
that referenced
this pull request
Jul 14, 2018
Export DefaultGenerator (formerly generator). Signed-off-by: Tim Heckman <t@heckman.io>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was decided that DefaultGenerator should be exported because the pattern of NewVx() functions was similar to patterns in Go standard library packages (http.DefaultClient, flag.CommandLine, etc.). These standard library packages export their defaults. It is also impractical to write testable code using the UUID library without writing a custom Generator to wrap the NewVx() functions without this interface being exported.