stop using UnixMill() to make legacy versions compatible #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylan-bourque
approved these changes
Oct 27, 2022
|
Everyone should definitely be updating to newer Go versions, but "We want to use |
|
@cameracker If you have time, I would appreciate your review. |
cameracker
approved these changes
Oct 31, 2022
|
Thanks a ton for identifying this issue and submitting a fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PR makes use of UnixMill() to get milli-precision timestamps.
#99
UnixMill() was added in go1.17, so it seems that the latest gofrs/uuid is not available from older versions of go.
According to Go's release policy, the last two versions of go are supported.
Therefore, I don't think it is a critical issue that it is not available for go versions older than go1.16.
However, since we expect some users to use older versions of go, we thought it would be better to stop using UnixMill().