Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve packing process #6

Closed
matfax opened this issue Nov 15, 2018 · 0 comments
Closed

Improve packing process #6

matfax opened this issue Nov 15, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@matfax
Copy link
Member

matfax commented Nov 15, 2018

Assuming a split up of the orb executors, jobs and commands, it is more idiomatic to generate a crosscutting scope for parameters and the respective arguments. Parameters could be derived implicitly from their usage and imported from a crosscutting scope where all parameters for executors, commands and jobs are defined.
A parameter is to be imported if it is passed over as argument or if it is used in the steps or executor section. To generify, parameters are always and only then to be imported if they are mentioned as << parameters.var >> at any place in the orb file before the import. Parameters that are not supposed to be imported in a crosscutting way, can still be specified and referenced directly in the file without the parameters. prefix.

@matfax matfax added the enhancement New feature or request label Nov 15, 2018
@matfax matfax closed this as completed in 13d8f8b Nov 18, 2018
@matfax matfax mentioned this issue Nov 27, 2018
Merged
autorebase bot pushed a commit that referenced this issue Nov 27, 2018
matfax added a commit that referenced this issue Nov 27, 2018
This reverts commit d55cc97.
@matfax matfax mentioned this issue Nov 27, 2018
matfax added a commit that referenced this issue Nov 27, 2018
Fixes #6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant