Add noproxy tests (#239)

* Update docu * Add additional noproxy tests
gogatekeeper · Dec 9, 2022 · 11ec1be · 11ec1be
1 parent 2c24adc
commit 11ec1be
Showing 1 changed file with 91 additions and 1 deletion.
diff --git a/server_test.go b/server_test.go
@@ -944,7 +944,7 @@ func TestNoProxy(t *testing.T) {
 		ExecutionSettings []fakeRequest
 	}{
 		{
-			Name: "TestEmptyXForwarded",
+			Name: "TestNoProxyWithNoRedirectsWhiteListed",
 			ProxySettings: func(c *Config) {
 				c.EnableDefaultDenyStrict = true
 				c.NoRedirects = true
@@ -972,6 +972,96 @@ func TestNoProxy(t *testing.T) {
 				},
 			},
 		},
+		{
+			Name: "TestNoProxyWithNoRedirectsPrivateUnauthenticated",
+			ProxySettings: func(c *Config) {
+				c.EnableDefaultDenyStrict = true
+				c.NoRedirects = true
+				c.NoProxy = true
+				c.Resources = []*authorization.Resource{
+					{
+						URL:         "/public/*",
+						Methods:     utils.AllHTTPMethods,
+						WhiteListed: true,
+					},
+					{
+						URL:     "/private",
+						Methods: []string{"GET"},
+					},
+				}
+			},
+			ExecutionSettings: []fakeRequest{
+				{
+					URI:           "/private",
+					ExpectedProxy: false,
+					ExpectedCode:  http.StatusUnauthorized,
+					ExpectedContent: func(body string, testNum int) {
+						assert.Equal(t, body, "")
+					},
+				},
+			},
+		},
+		{
+			Name: "TestNoProxyWithRedirectsPrivateUnauthenticated",
+			ProxySettings: func(c *Config) {
+				c.EnableDefaultDeny = true
+				c.NoRedirects = false
+				c.NoProxy = true
+				c.Resources = []*authorization.Resource{
+					{
+						URL:         "/public/*",
+						Methods:     utils.AllHTTPMethods,
+						WhiteListed: true,
+					},
+					{
+						URL:     "/private",
+						Methods: []string{"GET"},
+					},
+				}
+			},
+			ExecutionSettings: []fakeRequest{
+				{
+					URI:           "/private",
+					ExpectedProxy: false,
+					Redirects:     true,
+					ExpectedCode:  http.StatusSeeOther,
+					ExpectedContent: func(body string, testNum int) {
+						assert.Equal(t, body, "")
+					},
+				},
+			},
+		},
+		{
+			Name: "TestNoProxyWithRedirectsPrivateAuthenticated",
+			ProxySettings: func(c *Config) {
+				c.EnableDefaultDeny = true
+				c.NoRedirects = false
+				c.NoProxy = true
+				c.Resources = []*authorization.Resource{
+					{
+						URL:         "/public/*",
+						Methods:     utils.AllHTTPMethods,
+						WhiteListed: true,
+					},
+					{
+						URL:     "/private",
+						Methods: []string{"GET"},
+					},
+				}
+			},
+			ExecutionSettings: []fakeRequest{
+				{
+					URI:           "/private",
+					ExpectedProxy: false,
+					HasLogin:      true,
+					Redirects:     true,
+					ExpectedCode:  http.StatusOK,
+					ExpectedContent: func(body string, testNum int) {
+						assert.Equal(t, body, "")
+					},
+				},
+			},
+		},
 	}
 
 	for _, testCase := range testCases {