Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Games Not Installed #27

Closed
J23t opened this issue Dec 1, 2020 · 7 comments
Closed

Games Not Installed #27

J23t opened this issue Dec 1, 2020 · 7 comments

Comments

@J23t
Copy link

J23t commented Dec 1, 2020

Similar to #21 but the button says Install instead of Play. If you hover over the install button it will says Not compatible.

Install

This problem happens every time I start up GOG Galaxy 2.0.25 Beta.

I have a work around when I want to play a PS2 game. Instead of entering in the settings every time, I changed the default settings in config.py with my own, then disconnect and connect the integration.

@J23t
Copy link
Author

J23t commented Dec 12, 2020

Running GOG Galaxy 2.0.30 Beta and the issue no longer persist.

@J23t J23t closed this as completed Dec 12, 2020
@J23t
Copy link
Author

J23t commented Jan 10, 2021

Still have the issue. I think it was a fluke. Not sure if something is blocking the plugin from working.
Might be Windows Security? But I don't see any relevant blocked programs.

GOG Galaxy 2.0.35 Beta

Started up GOG Galaxy, PS2 games have Play button as Install and is disabled. Disconnected Plugin and Connected with same configs. Games can be launched.
Plugin Log

Line 3497 - Plugin Closed
Line 4132 - Game has been launched

Next time it locks up I will try to add a new game.
I added Gog into virus exclusions and allowed folder access to see if the issue persist.

@J23t J23t reopened this Jan 10, 2021
@J23t
Copy link
Author

J23t commented Jan 10, 2021

Just to make this clear. When I first started using this plugin, I had no problems for many days.
Then one day I booted up my system and my games won't launch from the plugin.
Nothing had changed besides the Gog client updating it's self within that period of time. Which is why I assumed it was Gog.

@J23t
Copy link
Author

J23t commented Jan 11, 2021

#28 Same problem? But I'm using the default mode.
I booted up this morning to see if it was greyed out and it was.

Play button disabled, Added new game into folder, Still broken, Reconnected plugin, Launched newer game with success.
Plugin Log

@ShadowMarter
Copy link

Appears to be the same problem. Sadly, I haven't found a solution yet.

@Demiko
Copy link

Demiko commented Feb 3, 2021

It seems like Galaxy client does not call the get_owned_games function upon starting this plugin (client bug?), so the procedure that scans the games directory is never called and the self.games object is never initialized.

I have fixed this locally by re-scanning the games directory if self.games list is empty upon calling _local_games_list. This is probably not the best solution, but it works.

Here's the snippet. I hope it helps.

    def _local_games_list(self) -> list:
        ''' Returns a list of LocalGame objects

        Goes through retrieved games and adds them as local games with default state of "Installed"
        '''
        if not self.games:
            self._update_games()
        local_games = []
        for game in self.games:
            state = LocalGameState.Installed
            if self.running_game_id == game.id:
                state |= LocalGameState.Running

            local_games.append(
                LocalGame(
                    game.id,
                    state
                )
            )
        return local_games

    def _update_games(self):
        self.config.cfg.read(os.path.expandvars(config.CONFIG_LOC))
        method = self.config.cfg.get("Method", "method")
        if(method == "default"):
            logging.debug("DEV: Default method has been chosen")
            self.games = self.ps2_client._get_games_database()
        elif(method == "giant"):
            logging.debug("DEV: Giant bomb method has been chosen")
            self.games = self.ps2_client._get_games_giant_bomb()
        else:
            logging.debug("DEV: ISO method has been chosen")
            self.games = self.ps2_client._get_games_read_iso()

@AHCoder
Copy link
Owner

AHCoder commented Sep 16, 2021

@AHCoder AHCoder closed this as completed Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants