Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSR validation blocks wildcard SSL #148

Closed
NatsumeReiu opened this issue Oct 7, 2020 · 8 comments
Closed

CSR validation blocks wildcard SSL #148

NatsumeReiu opened this issue Oct 7, 2020 · 8 comments

Comments

@NatsumeReiu
Copy link

The API decodeCSR returns below error message if the common name is a wildcard domain.
"The Common Name (Domain Name: *.futuregame.com.tw) may not contain a *. Please buy Wildcard SSL Certificate for that CSR"

In the function SSLStepTwoJS (defined in addons/SSLCENTERWHMCS/eServices/provisioning/SSLStepTwoJS.php), once detecting an error when decoding CSR, it will throw an exception and stop rendering JS for approval emails.

@DennisSkov
Copy link
Contributor

What version of the module are you using? AFAIK, that issue was fixed a long time ago.

@vlad-evg
Copy link
Contributor

vlad-evg commented Oct 7, 2020

and what is the product you are trying to order?

@NatsumeReiu
Copy link
Author

I have the issue with the latest version 2.4.10. I was trying to order PositiveSSL Wildcard.

@vlad-evg
Copy link
Contributor

vlad-evg commented Oct 7, 2020

can you provide CSR please?

@googlegame
Copy link

same problem, PositiveSSL Wildcard

@vlad-evg
Copy link
Contributor

Can you provide CSR code? We see no issues on our side

@NatsumeReiu
Copy link
Author

NatsumeReiu commented Oct 23, 2020

Here's a CSR,

----BEGIN CERTIFICATE REQUEST-----
[REMOVED FOR PRIVACY AFTER BUG FIXED]
-----END CERTIFICATE REQUEST-----

@vlad-evg
Copy link
Contributor

Fixed now #148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants