Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

单元测试完善：contrib/drivers/clickhouse #1815

Closed
gqcn opened this issue May 10, 2022 · 8 comments
Closed

单元测试完善：contrib/drivers/clickhouse #1815

gqcn opened this issue May 10, 2022 · 8 comments
Labels
done This issue is done, which may be release in next version. feature help wanted

Comments

@gqcn
Copy link
Member

gqcn commented May 10, 2022 •
edited by hailaz

完善社区组件 contrib/drivers/clickhouse 的单元测试。

组件地址：https://github.com/gogf/gf/tree/master/contrib/drivers/clickhouse

要求：

  1. 提供Model的CURD用例，至少包含这些方法的测试用例：
  • 模型：Model/Raw
  • 查询：All/One/Value/Array/Scan/Count
  • 条件：多条件Where组合用例
  • 写入：Insert/Replace/Save
  • 更新：Update
  • 删除：Delete
  1. 提供DB接口的CURD用例，至少包含这些方法的测试用例：
  • 原生：Query/Exec
  • 查询：GetAll/GetOne/GetValue/GetCount/GetArray/GetScan
  • 写入：Insert/Replace/Save
  • 更新：Update
  • 删除：Delete
  • 功能：Tables/TableFields 特别重要

注意事项：不支持的方法断言返回的错误即可。
@gqcn gqcn changed the title 单元测试完善：contrib/drivers/clickhouse 【开源摘星计划】单元测试完善：contrib/drivers/clickhouse May 10, 2022
@gqcn gqcn changed the title 【开源摘星计划】单元测试完善：contrib/drivers/clickhouse 单元测试完善：contrib/drivers/clickhouse May 10, 2022
@gqcn gqcn mentioned this issue May 10, 2022
Open
@lawrshen
Copy link

Can I work on this issue?

@gqcn
Copy link
Member Author

gqcn commented May 17, 2022

@DGuang21 Are you working on this?

@gqcn
Copy link
Member Author

gqcn commented May 18, 2022

Can I work on this issue?

Another clickhouse issue is being handled, the unit testing cases should be after that.

@DGuang21
Copy link
Member

Can I work on this issue?

After another PR process is completed, you can go to work

@lawrshen
Copy link

lawrshen commented May 18, 2022 •
edited

Can I work on this issue?

After another PR process is completed, you can go to work

tkx， I will complete it recently after that PR merged

@gqcn
Copy link
Member Author

gqcn commented May 18, 2022

#1772

@lawrshen
Copy link

I perhaps resign this job due to busy job and strangeness of clickhouse, sorry for that

@houseme houseme mentioned this issue Aug 11, 2022
Closed
@CCpro10
Copy link
Contributor

CCpro10 commented Oct 11, 2022

I'm planning to finish this

CCpro10 added a commit to CCpro10/gf that referenced this issue Oct 13, 2022
@CCpro10
test: finish clickhouse_init_test (gogf#1815)
7a42028
CCpro10 added a commit to CCpro10/gf that referenced this issue Oct 13, 2022
@CCpro10
test: finish clickhouse_db_test (gogf#1815)
67664b5
CCpro10 added a commit to CCpro10/gf that referenced this issue Oct 13, 2022
@CCpro10
test: finish clickhouse_model_test (gogf#1815)
99abc28
gqcn pushed a commit that referenced this issue Oct 13, 2022
@CCpro10
Add test for clickhouse #1815 (#2200)
e756f28
houseme pushed a commit that referenced this issue Oct 22, 2022
@CCpro10 @houseme
Add test for clickhouse #1815 (#2200)
7a7ba0b
@gqcn gqcn added done This issue is done, which may be release in next version. and removed inactive labels Jan 18, 2023
@gqcn gqcn closed this as completed Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
done This issue is done, which may be release in next version. feature help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gqcn @DGuang21 @lawrshen @CCpro10