Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade ClickHouse dependencies to V2 #1772

Merged
merged 22 commits into from
May 23, 2022
Merged

upgrade ClickHouse dependencies to V2 #1772

merged 22 commits into from
May 23, 2022

Conversation

DGuang21
Copy link
Member

@DGuang21 DGuang21 commented Apr 19, 2022

feature:

  • 底层 clickhouse-go 驱动升级到 V2
  • 使用正则去解析/匹配通用 update/delete 语句为 clickhouse 方言(sql parser 有明显缺陷,故弃之)
  • insert 方法兼容更多类型内容

@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2022

Codecov Report

Merging #1772 (04dd88e) into master (896b9fa) will increase coverage by 0.00%.
The diff coverage is 75.42%.

@@           Coverage Diff           @@
##           master    #1772   +/-   ##
=======================================
  Coverage   73.25%   73.25%           
=======================================
  Files         503      503           
  Lines       45392    45478   +86     
=======================================
+ Hits        33250    33313   +63     
- Misses      10115    10135   +20     
- Partials     2027     2030    +3     
Flag Coverage Δ
go-1.15-386 73.19% <75.42%> (+<0.01%) ⬆️
go-1.15-amd64 73.20% <75.42%> (-0.03%) ⬇️
go-1.16-386 73.20% <75.42%> (+0.01%) ⬆️
go-1.16-amd64 73.17% <75.42%> (-0.02%) ⬇️
go-1.17-386 73.19% <75.42%> (-0.02%) ⬇️
go-1.17-amd64 73.22% <75.42%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
contrib/drivers/clickhouse/clickhouse.go 69.62% <75.42%> (+3.44%) ⬆️
database/gdb/gdb_model_update.go 73.75% <0.00%> (-7.50%) ⬇️
os/glog/glog_logger_rotate.go 65.85% <0.00%> (-1.47%) ⬇️
container/gmap/gmap_hash_str_any_map.go 94.11% <0.00%> (-1.04%) ⬇️
database/gdb/gdb_core_structure.go 63.52% <0.00%> (+1.17%) ⬆️
os/gfsnotify/gfsnotify_watcher_loop.go 85.71% <0.00%> (+2.52%) ⬆️
contrib/registry/polaris/polaris_watcher.go 71.69% <0.00%> (+5.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 896b9fa...04dd88e. Read the comment docs.

contrib/drivers/README.md Show resolved Hide resolved
@DGuang21 DGuang21 requested a review from gqcn April 29, 2022 02:15
contrib/drivers/clickhouse/clickhouse.go Outdated Show resolved Hide resolved
contrib/drivers/clickhouse/clickhouse.go Show resolved Hide resolved
database/gdb/gdb_core_ctx.go Outdated Show resolved Hide resolved
@gqcn gqcn added the wip label May 17, 2022
@DGuang21 DGuang21 requested a review from gqcn May 17, 2022 13:54
@gqcn gqcn merged commit 8c969b2 into master May 23, 2022
@gqcn gqcn deleted the feature-clickhouse-driver branch May 27, 2022 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants