Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve Timezone escape for driver dm/mysql #2412

Merged
merged 3 commits into from
Feb 8, 2023
Merged

improve Timezone escape for driver dm/mysql #2412

merged 3 commits into from
Feb 8, 2023

Conversation

LonelySally
Copy link
Member

判定Timezone是否需要转义

@LonelySally LonelySally requested a review from gqcn February 2, 2023 02:09
@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2023

Codecov Report

Base: 79.63% // Head: 79.56% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (895fc0b) compared to base (a746794).
Patch coverage: 0.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2412      +/-   ##
==========================================
- Coverage   79.63%   79.56%   -0.07%     
==========================================
  Files         595      598       +3     
  Lines       49375    49718     +343     
==========================================
+ Hits        39318    39557     +239     
- Misses       8077     8164      +87     
- Partials     1980     1997      +17     
Flag Coverage Δ
go-1.15-386 79.56% <0.00%> (-0.06%) ⬇️
go-1.15-amd64 79.60% <0.00%> (+0.03%) ⬆️
go-1.16-386 79.58% <0.00%> (-0.01%) ⬇️
go-1.16-amd64 79.62% <0.00%> (+<0.01%) ⬆️
go-1.17-386 79.58% <0.00%> (?)
go-1.17-amd64 79.61% <0.00%> (?)
go-1.18-amd64 79.51% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
contrib/drivers/dm/dm.go 73.13% <0.00%> (-0.55%) ⬇️
contrib/drivers/mysql/mysql.go 68.00% <0.00%> (-1.39%) ⬇️
container/gmap/gmap_hash_str_any_map.go 97.00% <0.00%> (-1.00%) ⬇️
contrib/config/kubecm/kubecm.go 38.38% <0.00%> (ø)
contrib/drivers/oracle/oracle.go 79.45% <0.00%> (ø)
contrib/config/kubecm/kubecm_kube.go 100.00% <0.00%> (ø)
os/glog/glog_logger_rotate.go 64.70% <0.00%> (+1.35%) ⬆️
net/gtcp/gtcp_pool.go 75.55% <0.00%> (+6.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gqcn gqcn changed the title 判定Timezone是否需要转义 improve Timezone escape for driver dm/mysql Feb 8, 2023
@gqcn gqcn merged commit 013f8b2 into gogf:master Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants