Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiple interfaces cause the original type to be inaccessible #2915

Merged
merged 2 commits into from Sep 4, 2023

Conversation

wlynxg
Copy link
Contributor

@wlynxg wlynxg commented Aug 30, 2023

fix: #2665

Since v is of interface{} type, when v is assigned a value, the type of v is interface{}|time.Time, the function return type is interface{}, and the value type at this time is interface{}|*interface{}|time .Time, this will result in the original type time.Time not being available outside.

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (7d4c59a) 79.16% compared to head (42a7781) 79.15%.
Report is 2 commits behind head on master.

❗ Current head 42a7781 differs from pull request most recent head 4081869. Consider uploading reports for the commit 4081869 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2915      +/-   ##
==========================================
- Coverage   79.16%   79.15%   -0.01%     
==========================================
  Files         638      638              
  Lines       52557    52557              
==========================================
- Hits        41608    41603       -5     
- Misses       8884     8888       +4     
- Partials     2065     2066       +1     
Flag Coverage Δ
go-1.18-386 79.16% <100.00%> (-0.07%) ⬇️
go-1.18-amd64 79.23% <100.00%> (ø)
go-1.19-386 79.08% <100.00%> (-0.04%) ⬇️
go-1.19-amd64 79.11% <100.00%> (-0.04%) ⬇️
go-1.20-386 79.20% <100.00%> (-0.02%) ⬇️
go-1.20-amd64 79.14% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
util/gconv/gconv_convert.go 91.63% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gqcn
Copy link
Member

gqcn commented Aug 31, 2023

@wlynxg It's awesome! 💓 Would you please add associated unit testing case to cover this issue #2665 ?

@gqcn gqcn added the wip label Aug 31, 2023
@wlynxg
Copy link
Contributor Author

wlynxg commented Sep 1, 2023

@wlynxg It's awesome! 💓 Would you please add associated unit testing case to cover this issue #2665 ?

👌

@gqcn gqcn merged commit 097b26f into gogf:master Sep 4, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

*time. Time is inconsistent with time.Time conversion
3 participants