Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add unit tests regarding issue 2901 #2930

Merged
merged 1 commit into from Sep 5, 2023
Merged

test: add unit tests regarding issue 2901 #2930

merged 1 commit into from Sep 5, 2023

Conversation

wlynxg
Copy link
Contributor

@wlynxg wlynxg commented Sep 5, 2023

pr #2915 also fixes the problems mentioned in issue #2901. This submission adds unit tests for issue #2901.

@wlynxg wlynxg changed the title test: add unit tests regarding issue 2926 test: add unit tests regarding issue 2901 Sep 5, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2023

Codecov Report

Patch coverage: 77.15% and project coverage change: -0.02% ⚠️

Comparison is base (74bf1b4) 79.15% compared to head (df22652) 79.13%.
Report is 7 commits behind head on master.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2930      +/-   ##
==========================================
- Coverage   79.15%   79.13%   -0.02%     
==========================================
  Files         638      639       +1     
  Lines       52570    52607      +37     
==========================================
+ Hits        41611    41633      +22     
- Misses       8892     8908      +16     
+ Partials     2067     2066       -1     
Flag Coverage Δ
go-1.18-386 79.22% <77.15%> (+0.03%) ⬆️
go-1.18-amd64 79.21% <77.15%> (+0.01%) ⬆️
go-1.19-386 79.06% <77.15%> (-0.05%) ⬇️
go-1.19-amd64 79.04% <77.15%> (-0.07%) ⬇️
go-1.20-386 79.14% <77.15%> (-0.09%) ⬇️
go-1.20-amd64 79.17% <77.15%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
container/gmap/gmap_hash_str_any_map.go 98.20% <ø> (ø)
database/gdb/gdb.go 68.34% <ø> (ø)
database/gdb/gdb_result.go 36.00% <ø> (+3.85%) ⬆️
internal/instance/instance.go 100.00% <ø> (ø)
os/gcache/gcache.go 96.77% <ø> (ø)
os/gtime/gtime.go 86.93% <ø> (ø)
text/gregex/gregex_cache.go 100.00% <ø> (ø)
text/gstr/gstr_slashes.go 100.00% <ø> (ø)
text/gstr/gstr_sub.go 93.47% <ø> (ø)
contrib/drivers/dm/dm.go 69.70% <45.83%> (-0.55%) ⬇️
... and 20 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gqcn gqcn merged commit d49dccb into gogf:master Sep 5, 2023
9 checks passed
@wlynxg wlynxg deleted the gconv branch September 15, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants