-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(database/gredis): add Scan
method for incremental key retrieval
#3451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@gqcn Hi John, I'm looking forward to your review. If you need any information, pls don't hesitate contact me. |
gqcn
requested changes
Apr 7, 2024
hailaz
approved these changes
Apr 7, 2024
gqcn
requested changes
Apr 9, 2024
gqcn
approved these changes
Apr 11, 2024
Scan
method for incremental key retrieval in gredis
Scan
method for incremental key retrieval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request introduces the
Scan
method to theGroupGeneric
struct ingredis
package, providing an efficient and non-blocking approach to iterate over keys that match a given pattern in Redis. This method is designed to handle large datasets more gracefully than theKeys
command, offering incremental retrieval without the risk of blocking the Redis server.Changes
Scan
Method: Implements the RedisSCAN
command within theGroupGeneric
struct. It accepts a cursor, pattern, and count, returning a slice of keys matching the pattern and the next cursor position for continued scanning.Why It's Needed
The
SCAN
command is essential for applications dealing with large data sets in Redis, where using theKeys
command might lead to performance bottlenecks or blocking the server. By providing aScan
method, it easier and safer to get keys little by little, improving overall application responsiveness.Available since Redis version:
2.8.0
Usage Example
Below is a simple example demonstrating how to use the new
Scan
method:Testing
Includes comprehensive unit tests covering:
I'd love to hear your thoughts and feedback on this! Looking forward to your review.