Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to fix Duplicate of files in directory (gogs#2254 ) #3

Merged
merged 3 commits into from
Dec 29, 2015

Conversation

novaeye
Copy link
Contributor

@novaeye novaeye commented Dec 25, 2015

@@ -110,6 +110,7 @@ func (tes Entries) Sort() {

type commitInfo struct {
id string
entry string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use entryName should be better?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/nod, u r right!

@unknwon
Copy link
Member

unknwon commented Dec 25, 2015

Thanks your PR!

id string
infos []interface{}
err error
id string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since id was only used for identify the object, and now we use entryName, I think it can be removed.

@unknwon
Copy link
Member

unknwon commented Dec 29, 2015

Thanks!

You should ping me after update, GitHub does not send me notification for that...

unknwon added a commit that referenced this pull request Dec 29, 2015
try to fix  Duplicate of files in directory (gogs#2254 )
@unknwon unknwon merged commit 2617983 into gogs:master Dec 29, 2015
strk pushed a commit to strk/git-module that referenced this pull request Nov 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants