Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code review tool git-appraise intergration #2210

Open
lunny opened this issue Dec 16, 2015 · 27 comments
Open

Code review tool git-appraise intergration #2210

lunny opened this issue Dec 16, 2015 · 27 comments
Labels
🎯 feature Categorizes as related to a new feature ☁️ plugin Maybe one day, who knows

Comments

@lunny
Copy link
Contributor

lunny commented Dec 16, 2015

Since git-appraise will store code review data in refs/notes/devtools, gogs can read the data and show info on the web interface.

@unknwon unknwon changed the title Feature Request: code review tool git-appraise intergration Code review tool git-appraise intergration Dec 16, 2015
@unknwon unknwon added the 🎯 feature Categorizes as related to a new feature label Dec 16, 2015
@unknwon unknwon modified the milestones: 0.9.0, 0.10.0 Dec 16, 2015
@vtolstov
Copy link

Very nice! Waiting :)
16 дек. 2015 г. 5:44 пользователь "Lunny Xiao" notifications@github.com
написал:

Since git-appraise will store code review data in refs/notes/devtools,
gogs can read the data and show info on the web interface.


Reply to this email directly or view it on GitHub
#2210.

@hhenkel
Copy link

hhenkel commented Dec 16, 2015

This looks quite promising. Seems like github resolved only half the way with their implementation of pull requests, as this seems to store everything in git.

@AndreaGiardini
Copy link

Great idea!

@jeanlucmongrain
Copy link
Contributor

wonderful idea! been working with git appraise in the past few days and I really wish gogs could do that. Where can I send some bitcoin for that? :)

@favadi
Copy link

favadi commented Dec 22, 2015

Please tak @bclermont bitcoins and my words, it will be a game changer feature for gits. 👍

@linquize
Copy link
Contributor

Distributed code review tool.

@galaktor
Copy link

galaktor commented Feb 4, 2016

doing this would give gogs a significant edge over GitHub IMHO

@unknwon unknwon removed this from the 0.10.0 milestone Feb 7, 2016
@unknwon unknwon added the ☁️ plugin Maybe one day, who knows label Feb 22, 2016
@DirectorX
Copy link

+1

4 similar comments
@newsky
Copy link

newsky commented Apr 8, 2016

+1

@sluedecke
Copy link

+1

@langdead
Copy link

+1

@tgy
Copy link

tgy commented May 6, 2016

👍

@viklele
Copy link

viklele commented Jun 7, 2016

+1

@sergey-miryanov
Copy link

+1

@abourget
Copy link

oh yeah I'd sssoo much love to see that.. I'd even use Gogs merely as a UI for distributed review if we could have that in there ! git-appraise defines a new code review standard IMO

@LeKovr
Copy link

LeKovr commented Jun 17, 2016

+1

@Ritbit
Copy link

Ritbit commented Oct 21, 2016

+1

@MehSha
Copy link

MehSha commented Nov 2, 2016

+100

@ElForastero
Copy link

+1

1 similar comment
@Gorkov
Copy link

Gorkov commented Nov 7, 2016

+1

@oman36
Copy link

oman36 commented Nov 7, 2016

+1

@strk
Copy link
Contributor

strk commented Nov 7, 2016

All it takes is someone to propose a patch.
Consider sending your PRs to gite, for easier application:
https://github.com/go-gitea/gitea

@sluedecke
Copy link

At gitea there is a (currently stuck) first approach: go-gitea/gitea#733

@hsrzq
Copy link

hsrzq commented Apr 25, 2019

+1

@Russtopia
Copy link

Russtopia commented Dec 20, 2019

Everyone wanting a code review facility for gogs might want to consider this:

https://web.hypothes.is/

I tried it out on my private gogs install and it honestly does 99% of what I think a team would need for a code review. Nice interactive overlay on top of pull request pages. Create a private hypothes.is group for annotations for each repo/project, and the group's annotations will show up on PR pages wherever one highlights diffs for review.
screen

@jeanlucmongrain
Copy link
Contributor

jeanlucmongrain commented Dec 20, 2019

@Russtopia you're wasting your time with Gogs

Gitea is a fork of gogs, with a real community. and there had been code review for more than a year now.

@Russtopia
Copy link

Oh? I've been putting off trying a migration to Gitea... one more reason to try then! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯 feature Categorizes as related to a new feature ☁️ plugin Maybe one day, who knows
Projects
None yet
Development

No branches or pull requests