Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to comment on lines of code in a pull request #1644

Open
hhenkel opened this issue Sep 15, 2015 · 40 comments

Comments

@hhenkel
Copy link

commented Sep 15, 2015

It would be nice to have the possibility to comment on specific lines of a code in a pull request - as it is possible in github:

2015-09-15 13_51_58-added possibility to manage group members of a group by hhenkel pull request

Gitbucket (another github clone written in scala) has it already implemented.

@Unknwon Unknwon added this to the 0.8.0 milestone Sep 15, 2015

@Unknwon

This comment has been minimized.

Copy link
Member

commented Sep 15, 2015

This is what I'm wanting, but take some time to clean up previous tasks. 😃

@bhchew

This comment has been minimized.

Copy link

commented Sep 16, 2015

+1

1 similar comment
@nicolai86

This comment has been minimized.

Copy link
Contributor

commented Sep 19, 2015

+1

@john-hu

This comment has been minimized.

Copy link

commented Oct 14, 2015

+1

@roidelapluie

This comment has been minimized.

Copy link
Contributor

commented Dec 6, 2015

It would be great to be able to comment at the pull request level but also on individual commits.

@danielskowronski

This comment has been minimized.

Copy link

commented Dec 29, 2015

+1

1 similar comment
@wsantos

This comment has been minimized.

Copy link

commented Dec 30, 2015

+1

@AnonymousDeveloper13

This comment has been minimized.

Copy link

commented Dec 31, 2015

+9000000000000000000000000000000000001

@Unknwon Unknwon removed this from the 0.10.0 milestone Feb 7, 2016

@mikehaertl

This comment has been minimized.

Copy link

commented Mar 7, 2016

+1
For us this is one of the final main parts to make it basically feature complete. Having comments on code lines (and commits #796) is really a must. Would be a nice bonus for 0.10.0 ;)

@JonLundy

This comment has been minimized.

Copy link
Contributor

commented Mar 11, 2016

+1

3 similar comments
@redpist

This comment has been minimized.

Copy link

commented Mar 30, 2016

+1

@Chipsoid

This comment has been minimized.

Copy link

commented Apr 13, 2016

+1

@shah-dhaval

This comment has been minimized.

Copy link

commented Apr 15, 2016

+1

@estan

This comment has been minimized.

Copy link

commented Apr 26, 2016

@Unknwon: Any update on this? We're thinking of switching from an SVN based workflow to Git + Gogs, but we'd really need this feature. We currently do code review using a very manual process (patches + e-mail), but even there we can comment on sections of code inline :) In fact, I would say most comments are inline.

Great work on Gogs btw!

@Unknwon Unknwon added this to the 0.11.0 milestone Apr 26, 2016

@lostsnow

This comment has been minimized.

Copy link

commented Apr 27, 2016

+1 It is useful for review code in pull request

@ivanguajana

This comment has been minimized.

Copy link

commented May 2, 2016

+1

@theredcat

This comment has been minimized.

Copy link

commented May 25, 2016

@ work We use gitlab but I'm looking for an alternative since their update and deployment process was written by crazy monkey in lack of caffeine.

But since pull request code line comments feature is missing we won't be able to switch to gogs since this is mandatory to do easy code review

@patrickreck

This comment has been minimized.

Copy link

commented Jun 13, 2016

+1

@strk

This comment has been minimized.

Copy link
Contributor

commented Jun 14, 2016

May be possibly implemented via git-appraise ( #2210 )

@theredcat

This comment has been minimized.

Copy link

commented Jun 16, 2016

@strk As an ops, using the git-appraise cli would be fine for me. But some of my devs would like to have a nice UI to do this.

Frontend developpers, you know....

@strk

This comment has been minimized.

Copy link
Contributor

commented Jun 16, 2016

@theredcat yes I understand that, what I'm saying is that Gogs could just add a GUI to the git-appraise tool. That way users have a choice to either use the commandline or the GUI, and peer reviews would go togheter with the code when repository is cloned.

@theredcat

This comment has been minimized.

Copy link

commented Jun 16, 2016

@strk Thx for the clarification. This would be, indeed, a very nice approach

@tgy

This comment has been minimized.

Copy link

commented Jun 16, 2016

👍 git-appraise with a GUI sounds like the perfect road to follow

@stilet

This comment has been minimized.

Copy link

commented Aug 28, 2016

+1

@hhenkel

This comment has been minimized.

Copy link
Author

commented Aug 29, 2016

@strk I think git-appraise would do the job but from what I recall (not sure if it was on gitter or in an issue discussion) @Unknwon wants to keep the way gogs handles the pull request stuff. From my understanding that does result in haveing this implemented for the gogs native way of handling pull request and if someone does the git-appraise way of storing data it has to be handled differently. If the later is done I expect that a user/admin has to choose which implementation of PRs he wants to use.

@nfx

This comment has been minimized.

Copy link

commented Dec 29, 2016

this is a must

@snoozemoose

This comment has been minimized.

Copy link

commented Jan 3, 2017

+1

@videmort

This comment has been minimized.

Copy link

commented Jan 11, 2017

+9999999999

@MehSha

This comment has been minimized.

Copy link

commented Feb 6, 2017

+1

@eigan

This comment has been minimized.

Copy link
Contributor

commented Feb 6, 2017

STOP WITH '+1'

In many cases, especially on popular projects, the result is a long thread full of emoji and not much content, which makes it difficult to have a discussion. With reactions, you can now reduce the noise in these threads.

https://github.com/blog/2119-add-reactions-to-pull-requests-issues-and-comments

USE THAT!

I, and many others, are subscribed here for updates. Your '+1' is just making a mess.

@Unknwon Unknwon modified the milestones: 0.11.0, 0.12 Feb 18, 2017

@Unknwon Unknwon modified the milestones: 0.13, 0.12 Apr 7, 2017

@Unknwon Unknwon changed the title Add possibility to comment on lines of code in a pull request Ability to comment on lines of code in a pull request Apr 7, 2017

@Unknwon

This comment has been minimized.

Copy link
Member

commented Apr 7, 2017

Planned after #2109

richmahn referenced this issue in unfoldingWord-dev/dcs May 1, 2017

Limit clone depth when drone-building (#1644)
* Limit clone depth when drone-building

* sign drone
@federicobond

This comment has been minimized.

Copy link

commented Aug 14, 2017

Hi! Any updates on this issue?

@gogs gogs deleted a comment from snoozemoose Aug 15, 2017

@gogs gogs deleted a comment from danielskowronski Aug 16, 2017

@OsmeDiegoGH

This comment has been minimized.

Copy link

commented Sep 22, 2017

Hi, any updates to this request?

@kdrag0n

This comment has been minimized.

Copy link

commented Dec 18, 2017

Any updates now? It's almost 2018, and this issue was opened in 2015.

@kathiouchka

This comment has been minimized.

Copy link

commented Feb 8, 2018

Hello - Will this feature be implemented at all?

@gogs gogs deleted a comment from tgy Mar 4, 2018

@gogs gogs deleted a comment from ekermawi Mar 4, 2018

@gogs gogs deleted a comment from kathiouchka Mar 4, 2018

@Unknwon

This comment has been minimized.

Copy link
Member

commented Mar 4, 2018

Choose GitLab if you need feature-rich Git hosting! Seriously! Or just pay GitHub, it's just $7/month with unlimited private repositories. Or fork it, and do whatever you want!

Programmers, create the world with your own hands! Only managers ask features and just wait every single day!

@adventurist

This comment has been minimized.

Copy link

commented Apr 9, 2018

but a maintained Gogs with code comments is so much better than GitLab

@Unknwon Unknwon modified the milestones: 0.13, 0.12 Apr 9, 2018

@gogs gogs deleted a comment from Freddis May 23, 2018

@forestbelton

This comment has been minimized.

Copy link

commented Nov 27, 2018

What needs to be done so that this can become a reality? I see that there may be a dependency on #2109, but I don't see any progress on that issue.

@ptman

This comment has been minimized.

Copy link
Contributor

commented Nov 27, 2018

@forestbelton at the risk of getting this comment deleted, gitea has comments available in the 1.6.0 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.