Ability to comment on lines of code in a pull request

[hhenkel]

It would be nice to have the possibility to comment on specific lines of a code in a pull request - as it is possible in github:

Gitbucket (another github clone written in scala) has it already implemented.

[unknwon]

This is what I'm wanting, but take some time to clean up previous tasks. 😃

[bhchew]

+1

[nicolai86]

+1

[john-hu]

+1

[roidelapluie]

It would be great to be able to comment at the pull request level but also on individual commits.

[danielskowronski]

+1

[wsantos]

+1

[DarthMDev]

+9000000000000000000000000000000000001

[mikehaertl]

+1
For us this is one of the final main parts to make it basically feature complete. Having comments on code lines (and commits #796) is really a must. Would be a nice bonus for 0.10.0 ;)

[jonlundy]

+1

[redpist]

+1

[Chipsoid]

+1

[shah-dhaval]

+1

[estan]

@unknwon: Any update on this? We're thinking of switching from an SVN based workflow to Git + Gogs, but we'd really need this feature. We currently do code review using a very manual process (patches + e-mail), but even there we can comment on sections of code inline :) In fact, I would say most comments are inline.

Great work on Gogs btw!

[lostsnow]

+1 It is useful for review code in pull request

[ivanguajana]

+1

[theredcat]

@ work We use gitlab but I'm looking for an alternative since their update and deployment process was written by crazy monkey in lack of caffeine.

But since pull request code line comments feature is missing we won't be able to switch to gogs since this is mandatory to do easy code review

[patrickreck]

+1

[strk]

May be possibly implemented via git-appraise ( #2210 )

[theredcat]

@strk As an ops, using the git-appraise cli would be fine for me. But some of my devs would like to have a nice UI to do this.

Frontend developpers, you know....

[strk]

@theredcat yes I understand that, what I'm saying is that Gogs could just add a GUI to the git-appraise tool. That way users have a choice to either use the commandline or the GUI, and peer reviews would go togheter with the code when repository is cloned.

[theredcat]

@strk Thx for the clarification. This would be, indeed, a very nice approach

[tgy]

👍 git-appraise with a GUI sounds like the perfect road to follow

[stilet]

+1

[hhenkel]

@strk I think git-appraise would do the job but from what I recall (not sure if it was on gitter or in an issue discussion) @unknwon wants to keep the way gogs handles the pull request stuff. From my understanding that does result in haveing this implemented for the gogs native way of handling pull request and if someone does the git-appraise way of storing data it has to be handled differently. If the later is done I expect that a user/admin has to choose which implementation of PRs he wants to use.

[unknwon]

Planned after #2109

[federicobond]

Hi! Any updates on this issue?

[OsmeDiegoGH]

Hi, any updates to this request?

[kdrag0n]

Any updates now? It's almost 2018, and this issue was opened in 2015.

[kathiouchka]

Hello - Will this feature be implemented at all?

[unknwon]

Choose GitLab if you need feature-rich Git hosting! Seriously! Or just pay GitHub, it's just $7/month with unlimited private repositories. Or fork it, and do whatever you want!

Programmers, create the world with your own hands! Only managers ask features and just wait every single day!

[adventurist]

but a maintained Gogs with code comments is so much better than GitLab

[forestbelton]

What needs to be done so that this can become a reality? I see that there may be a dependency on #2109, but I don't see any progress on that issue.

[ptman]

@forestbelton at the risk of getting this comment deleted, gitea has comments available in the 1.6.0 release

[minias]

Are you going to update it?

[lcalaresu]

I'm interested into this. Is anyone already wordking on it ?

[christopherstock]

Any updates on this major missing feature in Gogs? 👍

[ivanbogomoloff]

i start made this feature, but my progress is slow
my progress and discussion will be here for public https://discuss.gogs.io/t/line-number-commenting-on-pull-request/2668/3

branch here https://github.com/ivanbogomoloff/gogs/commits/feature/1644/ability-comment-pr

nowaday i implemented:

• simple ui on html+js (add, delete, markdown render)
• http post endpoint with send comment data and response rendered code comment
  but now it very raw

i plan finish this feature in very very simple implementation to august, i hope do it

[Aleksei-Badyaev]

The developers of Gogs have no plans at all to implement this great feature?

[timstableford]

Fyi, it is possible in Gitea now which is a fork of Gogs

…

On Tue, 4 May 2021 at 06:49, Aleksei Badyaev ***@***.***> wrote: The developers of Gogs have no plans at all to implement this great feature? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1644 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AALUPNHKFVSRQJXC5LBB7C3TL6DH5ANCNFSM4BPWIHGQ> .