Workaround delete folder on Windows. #2570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| if setting.IsWindows { | ||
| if err := exec.Command("cmd", "/C", "rmdir", "/S", "/Q", path).Run(); err != nil { | ||
| createNotice(err) |
There was a problem hiding this comment.
Maybe you can just call this only after if-else block?
|
Cool! |
unknwon
added a commit
that referenced
this pull request
Feb 7, 2016
Workaround delete folder on Windows.
ethantkoenig
pushed a commit
to ethantkoenig/gogs
that referenced
this pull request
Nov 10, 2017
* add external markup render support * bug fixed * refacotr codes and fix wrong error log * fix comments and add check to prevent leaks * add check for config file and improve the example * check file close error * use ioutil.TempFile instead uuid * correct Render -> Parser * improve warning when incorrect markup setting * fix typos
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1738
I tested and it is working properly. The folder is really deleted and I could create another repo with the same name.