More Issue-Comments API-endpoints #3624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkcsoft
commented
Sep 22, 2016
| m.Group("/:index", func() { | ||
| m.Combo("").Get(repo.GetIssue).Patch(bind(api.EditIssueOption{}), repo.EditIssue) | ||
|
|
||
| m.Group("/comments", func() { | ||
| m.Combo("").Get(repo.ListIssueComments).Post(bind(api.CreateIssueCommentOption{}), repo.CreateIssueComment) | ||
| m.Combo("/:id").Patch(bind(api.EditIssueCommentOption{}), repo.EditIssueComment) | ||
| m.Combo("/:id").Patch(bind(api.EditIssueCommentOption{}), repo.EditIssueComment). | ||
| Delete(repo.DeleteIssueComment) |
There was a problem hiding this comment.
These should probably be removed as they are redundant and non-compliant
|
This would be great to have this ported to Gitea! :) |
dbalexandre
pushed a commit
to gitlabhq/gitlabhq
that referenced
this pull request
Dec 21, 2016
It adds a brand new importer for Gitea! This is a continuation of !6945 started by @bkc. Gitea aims to be 100% GitHub-compatible but there's a few differences: - Gitea is not an OAuth provider (yet): go-gitea/gitea#27 - This means we cannot map Gitea users given an assignee ID => assignees are not set on imported issues and merge requests - No releases API for now: go-gitea/gitea#330 - API version is `v1` (GitHub is `v3`) - The IID field for milestones is `id` compared to `number` in GitHub. - Issues, PRs, milestones, labels don't have a `url` field (the importer now fallback to `''` in that case) **Known issues:** - Comments are not imported because comments JSON always have a blank `html_url`/`issue_url`/`pull_request_url`, so the IID cannot be extracted and the issuable cannot be found... :( This is tracked in go-gitea/gitea#401, and solved by gogs/gogs#3624 but this needs to be submitted / merged in Gitea. This is noted in the documentation. ## Are there points in the code the reviewer needs to double check? 1. I've made `Import::GiteaController` inherit from `Import::GithubController` since both controllers should be identical in the long-term and their current differences are small. 1. I've added a base `IssuableFormatter` class from which `IssueFormatter` & `PullRequestFormatter` inherit 1. I've added shared examples for GitHub/Gitea importer classes 1. I've made `Gitlab::ImportSources` more robust and tested! 🎄 1. I've added routing specs for import routes! 🎄 Closes #22348 See merge request !8116
|
Thanks! But can't see why #3673 relates to this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements Deletion of Issue-comments and Listing all issue-comments in a Repo
https://developer.github.com/v3/issues/comments/#delete-a-comment
https://developer.github.com/v3/issues/comments/#list-comments-in-a-repository
Edit: Closes #3673
See gogs/go-gogs-client#48
Adds 2 new Endpoints:
List all issue-comments for a given Repository
Issue Comments are ordered by ascending ID.
Parameters
2006-01-02T15:04:05Z07:00Response
[ { "id": 74, "user": { "id": 1, "username": "unknwon", "full_name": "无闻", "email": "u@gogs.io", "avatar_url": "http://localhost:3000/avatars/1" }, "body": "what?", "created_at": "2016-08-26T11:58:18-07:00", "updated_at": "2016-08-26T11:58:18-07:00" } ]Delete a Issue-comment
Response