Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release API #330

Closed
thibaultmeyer opened this issue Dec 1, 2016 · 4 comments
Closed

Release API #330

thibaultmeyer opened this issue Dec 1, 2016 · 4 comments
Labels
type/enhancement An improvement of existing functionality type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.
Milestone
1.1.0

Comments

@thibaultmeyer
Copy link
Contributor

thibaultmeyer commented Dec 1, 2016 •
edited
Loading

Add ability from the API to retrieve, at least, created releases. If methods like create / edit / delete are implemented too, it would be nice.
@lunny lunny added type/enhancement An improvement of existing functionality type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first. labels Dec 2, 2016
@lunny lunny added this to the 1.1.0 milestone Dec 2, 2016
@bkcsoft
Copy link
Member

bkcsoft commented Dec 2, 2016

I was about to add this, but it felt unnecessary as Gitea doesn't really have anything useful in there... Once Gitea has support for attachments it might be more interesting. Until then you can just fetch Tags 🙂

@thibaultmeyer
Copy link
Contributor Author

Ok.

Actually, we want to use it to avoid to duplicate changelog information. Our webapps will implement Gitea API to retrieve Release content and display it.

@bkcsoft
Copy link
Member

bkcsoft commented Dec 2, 2016

Fair enough, I'll have a look at it since other things I work on needs it as well

https://developer.github.com/v3/repos/releases/#get-a-single-release

@bkcsoft bkcsoft mentioned this issue Dec 2, 2016
Closed
dbalexandre pushed a commit to gitlabhq/gitlabhq that referenced this issue Dec 21, 2016
@rymai
Merge branch '22348-gitea-importer' into 'master'
367b68a 
It adds a brand new importer for Gitea!

This is a continuation of !6945 started by @bkc.

Gitea aims to be 100% GitHub-compatible but there's a few differences:

- Gitea is not an OAuth provider (yet): go-gitea/gitea#27
  - This means we cannot map Gitea users given an assignee ID => assignees are not set on imported issues and merge requests
- No releases API for now: go-gitea/gitea#330
- API version is `v1` (GitHub is `v3`)
- The IID field for milestones is `id` compared to `number` in GitHub.
- Issues, PRs, milestones, labels don't have a `url` field (the importer now fallback to `''` in that case)

**Known issues:**

- Comments are not imported because comments JSON always have a blank `html_url`/`issue_url`/`pull_request_url`, so the IID cannot be extracted and the issuable cannot be found... :( This is tracked in go-gitea/gitea#401, and solved by gogs/gogs#3624 but this needs to be submitted / merged in Gitea.

This is noted in the documentation.

## Are there points in the code the reviewer needs to double check?

1. I've made `Import::GiteaController` inherit from `Import::GithubController` since both controllers should be identical in the long-term and their current differences are small.
1. I've added a base `IssuableFormatter` class from which `IssueFormatter` & `PullRequestFormatter` inherit
1. I've added shared examples for GitHub/Gitea importer classes
1. I've made `Gitlab::ImportSources` more robust and tested! 🎄 
1. I've added routing specs for import routes! 🎄 

Closes #22348

See merge request !8116
@ethantkoenig
Copy link
Member

#510 😃

@ethantkoenig ethantkoenig mentioned this issue Dec 28, 2016
Merged
@lunny lunny closed this as completed Jan 5, 2017
ethantkoenig pushed a commit to ethantkoenig/gitea that referenced this issue Jan 5, 2017
@richmahn
Merge pull request go-gitea#98 from richmahn/feature/330-create-hasht…
d8c2ef7 
…ag-table-in-db

go-gitea#330 - Create hashtag table in DB
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/enhancement An improvement of existing functionality type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
4 participants
@lunny @thibaultmeyer @bkcsoft @ethantkoenig