fix: blob lost and lack mutex protection #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
imeoer
reviewed
Oct 20, 2023
imeoer
reviewed
Oct 20, 2023
PerseidMeteor
force-pushed
the
fix-blob-lost
branch
5 times, most recently
from
8c3fcac
to
51cade8
Compare
imeoer
reviewed
Oct 23, 2023
If use info varible in update and get error in store update, the return value info is empty, and cache update will be useless.And Update func of cache needs a mutex protection Signed-off-by: YuQiang <y_q_email@163.com>
PerseidMeteor
force-pushed
the
fix-blob-lost
branch
from
51cade8
to
a39f435
Compare
imeoer
reviewed
Oct 23, 2023
PerseidMeteor
force-pushed
the
fix-blob-lost
branch
5 times, most recently
from
aa03a43
to
879220a
Compare
add cached layer info in a conversion.eg. converted image xxx(cached 10/13) Signed-off-by: YuQiang <y_q_email@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If use
infovarible inUpdateof store and get error in store update, the return valueinfois empty, and cacheUpdatewill be useless.change:
infotoupdateInfoin content wrapUpdatefunc of cache needs a mutex protection"pulled image xxx(cached 21/23)"
"......"
"converted image xxx(cached 21/23)"
"......"