Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nydusify: integrate-acceld-cache #1446

Merged

Conversation

PerseidMeteor
Copy link

Relevant Issue (if applicable)

If there are Issues related to this PullRequest, please list it.

Details

update: integrate-acceld-cacheIntegrate acceld cache module

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@PerseidMeteor PerseidMeteor requested a review from a team as a code owner October 20, 2023 02:39
@PerseidMeteor PerseidMeteor requested review from bergwolf, liubin and imeoer and removed request for a team October 20, 2023 02:39
@PerseidMeteor
Copy link
Author

this pr should after this goharbor/acceleration-service#220

@PerseidMeteor PerseidMeteor changed the title update: integrate-acceld-cacheIntegrate acceld cache module nydusify: integrate-acceld-cache Oct 20, 2023
@PerseidMeteor PerseidMeteor force-pushed the feat-integrate-acceld-cache branch 3 times, most recently from 860d699 to 487fbdc Compare October 24, 2023 01:53
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #1446 (a0e1115) into master (6dc9144) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1446      +/-   ##
==========================================
- Coverage   46.34%   46.33%   -0.01%     
==========================================
  Files         123      123              
  Lines       38896    38896              
  Branches    38896    38896              
==========================================
- Hits        18025    18023       -2     
- Misses      19898    19899       +1     
- Partials      973      974       +1     

see 3 files with indirect coverage changes

@PerseidMeteor PerseidMeteor reopened this Oct 24, 2023
@PerseidMeteor PerseidMeteor force-pushed the feat-integrate-acceld-cache branch 4 times, most recently from a78d3ff to 094bf84 Compare October 27, 2023 03:41
Signed-off-by: YuQiang <y_q_email@163.com>
Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@imeoer imeoer merged commit 46fc724 into dragonflyoss:master Oct 27, 2023
24 checks passed
@PerseidMeteor PerseidMeteor deleted the feat-integrate-acceld-cache branch October 27, 2023 09:24
@imeoer imeoer mentioned this pull request Nov 2, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants