Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errdefs: add timeout case for NeedsRetryWithHTTP #290

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

imeoer
Copy link
Collaborator

@imeoer imeoer commented Jun 5, 2024

For some registry servers whose gateway has https on port 443 but
does not forward the request to the registry server, an io timeout
error occurs and we may need to fallback to http as well.

For some registry servers whose gateway has https on port 443 but
does not forward the request to the registry server, an io timeout
error occurs and we may need to fallback to http as well.

Signed-off-by: Yan Song <yansong.ys@antgroup.com>
@imeoer imeoer requested a review from Desiki-high June 5, 2024 06:46
Copy link
Collaborator

@Desiki-high Desiki-high left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imeoer imeoer merged commit 7000e66 into goharbor:main Jun 5, 2024
8 checks passed
imeoer added a commit to imeoer/image-service that referenced this pull request Jun 5, 2024
To bring the fixup: goharbor/acceleration-service#290

Signed-off-by: Yan Song <yansong.ys@antgroup.com>
imeoer added a commit to imeoer/image-service that referenced this pull request Jun 6, 2024
To bring the fixup: goharbor/acceleration-service#290

Signed-off-by: Yan Song <yansong.ys@antgroup.com>
imeoer added a commit to dragonflyoss/nydus that referenced this pull request Jun 6, 2024
To bring the fixup: goharbor/acceleration-service#290

Signed-off-by: Yan Song <yansong.ys@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants