Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proposal for Security Hub feature #228

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Jun 12, 2023

Add proposal for Security Hub feature

Copy link

@dioguerra dioguerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome!

proposals/new/cve_search_report.md Outdated Show resolved Hide resolved
proposals/new/cve_search_report.md Outdated Show resolved Hide resolved
@stonezdj stonezdj changed the title Add proposal for CVE report and search feature Add proposal for Security Hub feature Jun 27, 2023
wy65701436
wy65701436 previously approved these changes Jul 26, 2023
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

chlins
chlins previously approved these changes Aug 15, 2023
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

zyyw
zyyw previously approved these changes Aug 15, 2023
@stonezdj stonezdj dismissed stale reviews from zyyw and chlins via a7f74ee August 16, 2023 02:42
Signed-off-by: stonezdj <stonezdj@gmail.com>
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj merged commit 016139a into goharbor:main Aug 18, 2023
1 check passed
@OrlinVasilev
Copy link
Member

@stonezdj maybe now we have to move this to completed proposals ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants