Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

liveness probe may be problematic in upgrade #502

Closed
reasonerjt opened this issue Feb 4, 2020 · 2 comments · Fixed by #732
Closed

liveness probe may be problematic in upgrade #502

reasonerjt opened this issue Feb 4, 2020 · 2 comments · Fixed by #732
Assignees
@reasonerjt
Labels
target/1.5.0

Comments

@reasonerjt
Copy link
Contributor

reasonerjt commented Feb 4, 2020 •
edited
Loading

Currently the liveness probe of core calls the ping api for checking the liveness.
https://github.com/goharbor/harbor-helm/blob/master/templates/core/core-dpl.yaml#L38

Although the initial delay is configurable, the core may do migration work before serving the requests and the time is not easy to predict. it's possible that the probe may kill the pod when the migration is in progress, which will cause data in consistency.

We should consider other why for the probe.
@reasonerjt reasonerjt self-assigned this Jul 10, 2020
@reasonerjt
Copy link
Contributor Author

I think we should not check liveness by calling the API for harbor-core.

reasonerjt added a commit to reasonerjt/harbor-helm that referenced this issue Sep 15, 2020
@reasonerjt
Add startup probe to harbor-core
d912dd8 
Fixes goharbor#502

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
@reasonerjt
Copy link
Contributor Author

Startup probe seems a good option:
https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probe

I'll add it and it means the chart v1.5.0 can't be deployed on k8s version < 1.16

reasonerjt added a commit to reasonerjt/harbor-helm that referenced this issue Sep 17, 2020
@reasonerjt
Add startup probe to harbor-core
7a55206 
Fixes goharbor#502

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
@reasonerjt reasonerjt mentioned this issue Sep 17, 2020
Merged
reasonerjt added a commit to reasonerjt/harbor-helm that referenced this issue Sep 18, 2020
@reasonerjt
Add startup probe to harbor-core
2052c78 
Fixes goharbor#502

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reasonerjt reasonerjt

Labels
target/1.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add startup probe to harbor-core reasonerjt/harbor-helm
1 participant
@reasonerjt