Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop ScanAll not work in case of lots of artifacts. #18044

Closed
chlins opened this issue Jan 3, 2023 · 2 comments · Fixed by #18680
Closed

Stop ScanAll not work in case of lots of artifacts. #18044

chlins opened this issue Jan 3, 2023 · 2 comments · Fixed by #18680
Assignees
@chlins
Labels
area/vulnerability-scan target/2.9.0

Comments

@chlins
Copy link
Member

chlins commented Jan 3, 2023

How can we help you?

  1. Prepare a harbor instance with 10w artifacts.
  2. Trigger Scan ALL.
  3. Trigger Stop Scan.

The jobs still be enqueued to the jobservice, and the success job numbers keep increasing which not reasonable.

image

image
@github-actions
Copy link

This issue is being marked stale due to a period of inactivity. If this issue is still relevant, please comment or remove the stale label. Otherwise, this issue will close in 30 days.

@github-actions github-actions bot added the Stale label Mar 10, 2023
@zyyw zyyw mentioned this issue Mar 16, 2023
Closed
5 tasks
@zyyw zyyw assigned chlins and unassigned zyyw Mar 17, 2023
@zyyw
Copy link
Contributor

zyyw commented Mar 17, 2023 •
edited

The execution status is currently not refreshed into database properly. We may need further investigation on that first.

Mar 16 09:44:27 harbor-sc3 core[242959]: 2023-03-16T09:44:27Z [ERROR] [/lib/http/error.go:56]: {"errors":[{"code":"UNKNOWN","message":"unknown: failed to refresh the status of the execution 2 after 5 retries"}]}

@zyyw zyyw self-assigned this Mar 17, 2023
@chlins chlins mentioned this issue Apr 20, 2023
Closed
chlins added a commit to chlins/harbor that referenced this issue May 16, 2023
@chlins
fix: add checkpoint when enqueue scan tasks for scan all
92b9584 
Fix the scanAll cannot be stopped in case of large number of artifacts,
add the checkpoint before submit scan tasks, mark the scanAll stopped
flag in the redis.

Fixes: goharbor#18044

Signed-off-by: chlins <chenyuzh@vmware.com>
@chlins chlins mentioned this issue May 16, 2023
Merged
5 tasks
chlins added a commit to chlins/harbor that referenced this issue Jun 1, 2023
@chlins
fix: add checkpoint when enqueue scan tasks for scan all
84b3a7c 
Fix the scanAll cannot be stopped in case of large number of artifacts,
add the checkpoint before submit scan tasks, mark the scanAll stopped
flag in the redis.

Fixes: goharbor#18044

Signed-off-by: chlins <chenyuzh@vmware.com>
chlins added a commit to chlins/harbor that referenced this issue Jun 2, 2023
@chlins
fix: add checkpoint when enqueue scan tasks for scan all
285155a 
Fix the scanAll cannot be stopped in case of large number of artifacts,
add the checkpoint before submit scan tasks, mark the scanAll stopped
flag in the redis.

Fixes: goharbor#18044

Signed-off-by: chlins <chenyuzh@vmware.com>
chlins added a commit to chlins/harbor that referenced this issue Jun 5, 2023
@chlins
fix: add checkpoint when enqueue scan tasks for scan all
f0c6912 
Fix the scanAll cannot be stopped in case of large number of artifacts,
add the checkpoint before submit scan tasks, mark the scanAll stopped
flag in the redis.

Fixes: goharbor#18044

Signed-off-by: chlins <chenyuzh@vmware.com>
chlins added a commit that referenced this issue Jun 5, 2023
@chlins
fix: add checkpoint when enqueue scan tasks for scan all (#18680)
fbeeaa7 
Fix the scanAll cannot be stopped in case of large number of artifacts,
add the checkpoint before submit scan tasks, mark the scanAll stopped
flag in the redis.

Fixes: #18044

Signed-off-by: chlins <chenyuzh@vmware.com>
WilfredAlmeida pushed a commit to WilfredAlmeida/harbor that referenced this issue Jul 8, 2023
@chlins @WilfredAlmeida
fix: add checkpoint when enqueue scan tasks for scan all (goharbor#18680
5993ad3 
)

Fix the scanAll cannot be stopped in case of large number of artifacts,
add the checkpoint before submit scan tasks, mark the scanAll stopped
flag in the redis.

Fixes: goharbor#18044

Signed-off-by: chlins <chenyuzh@vmware.com>
Signed-off-by: Wilfred Almeida <60785452+WilfredAlmeida@users.noreply.github.com>
WilfredAlmeida pushed a commit to WilfredAlmeida/harbor that referenced this issue Jul 8, 2023
@chlins @WilfredAlmeida
fix: add checkpoint when enqueue scan tasks for scan all (goharbor#18680
4734cf5 
)

Fix the scanAll cannot be stopped in case of large number of artifacts,
add the checkpoint before submit scan tasks, mark the scanAll stopped
flag in the redis.

Fixes: goharbor#18044

Signed-off-by: chlins <chenyuzh@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chlins chlins

Labels
area/vulnerability-scan target/2.9.0
Projects
None yet
Milestone
No milestone
3 participants
@stonezdj @zyyw @chlins