fix: add checkpoint when enqueue scan tasks for scan all #18680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #18680 +/- ##
===========================================
- Coverage 67.34% 44.78% -22.56%
===========================================
Files 980 235 -745
Lines 106829 13067 -93762
Branches 2665 2665
===========================================
- Hits 71943 5852 -66091
+ Misses 31019 6921 -24098
+ Partials 3867 294 -3573
Flags with carried forward coverage won't be shown. Click here to find out more. |
stonezdj
approved these changes
Jun 1, 2023
chlins
force-pushed
the
fix/stop-scanall
branch
2 times, most recently
from
84b3a7c
to
285155a
Compare
Fix the scanAll cannot be stopped in case of large number of artifacts, add the checkpoint before submit scan tasks, mark the scanAll stopped flag in the redis. Fixes: goharbor#18044 Signed-off-by: chlins <chenyuzh@vmware.com>
WilfredAlmeida
pushed a commit
to WilfredAlmeida/harbor
that referenced
this pull request
Jul 8, 2023
) Fix the scanAll cannot be stopped in case of large number of artifacts, add the checkpoint before submit scan tasks, mark the scanAll stopped flag in the redis. Fixes: goharbor#18044 Signed-off-by: chlins <chenyuzh@vmware.com> Signed-off-by: Wilfred Almeida <60785452+WilfredAlmeida@users.noreply.github.com>
WilfredAlmeida
pushed a commit
to WilfredAlmeida/harbor
that referenced
this pull request
Jul 8, 2023
) Fix the scanAll cannot be stopped in case of large number of artifacts, add the checkpoint before submit scan tasks, mark the scanAll stopped flag in the redis. Fixes: goharbor#18044 Signed-off-by: chlins <chenyuzh@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the scanAll cannot be stopped in case of large number of artifacts, add the checkpoint before submit scan tasks, mark the scanAll stopped flag in the redis.
Fixes: #18044
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #18044
Please indicate you've done the following: