Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure the skinnable configuration file setting.json is built into the image #3879

Closed
steven-zou opened this issue Dec 26, 2017 · 2 comments
Closed

Make sure the skinnable configuration file setting.json is built into the image #3879

steven-zou opened this issue Dec 26, 2017 · 2 comments
Labels
area/ui kind/bug target/vic-1.3
Milestone
Sprint 25

Comments

@steven-zou
Copy link
Contributor

"projects": {
"companyName": "vmware",
"projectName": "Harbor",
"introduction": {
"zh-cn": "",
"es-es": "",
"en-us": ""
}
}

projects should be changed to 'product'
@steven-zou steven-zou added this to the Sprint 25 milestone Dec 26, 2017
@reasonerjt reasonerjt mentioned this issue Jan 3, 2018
Closed
pengpengshui added a commit to pengpengshui/harbor that referenced this issue Jan 4, 2018
@pengpengshui
Modify skinnable json file and modify image path about goharbor#3909 g…
42122e1 
…oharbor#3879
pengpengshui added a commit to pengpengshui/harbor that referenced this issue Jan 4, 2018
@pengpengshui
Modify skinnable json file and modify image path about goharbor#3909 g…
7845405 
…oharbor#3879
pengpengshui added a commit that referenced this issue Jan 4, 2018
@pengpengshui
Merge pull request #3910 from pengpengshui/skinable
a75f347 
Modify skinnable json file and modify images path about #3909 #3879
pengpengshui added a commit to pengpengshui/harbor that referenced this issue Jan 4, 2018
@pengpengshui
Modify skinnable json file and modify image path about goharbor#3909 g…
42aa1bd 
…oharbor#3879
pengpengshui added a commit that referenced this issue Jan 4, 2018
@pengpengshui
Merge pull request #3926 from pengpengshui/cherry_skinnable
76f8882 
Modify skinnable json file and modify image path about #3909 #3879
@reasonerjt
Copy link

@steven-zou I believe this is fixed in release 1.3.0 correct?

@pengpengshui
Copy link
Contributor

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ui kind/bug target/vic-1.3
Projects
None yet
Milestone
Sprint 25
Development

No branches or pull requests
3 participants
@reasonerjt @steven-zou @pengpengshui