Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong path of setting.json #3909

Closed
steven-zou opened this issue Jan 3, 2018 · 6 comments
Closed

Wrong path of setting.json #3909

steven-zou opened this issue Jan 3, 2018 · 6 comments

Comments

@steven-zou
Copy link
Contributor

When getting the setting.json, should add prefix path 'static/'

If setting.json failed to load, default styles should be applied. But bug found in the background image of login page;

style="background-image: url("undefined");"

@reasonerjt
Copy link

@steven-zou How does this relates to #3879 ?

@mdubya66
Copy link

mdubya66 commented Jan 4, 2018

is this a 1.3 Ship stopper? @reasonerjt?

@reasonerjt
Copy link

@mdubya66 It's not.

@mdubya66
Copy link

mdubya66 commented Jan 4, 2018

thanks, i saw the target/vic-1.3 label

@reasonerjt
Copy link

reasonerjt commented Jan 4, 2018

@mdubya66 it only impacts a use case of community user using standalone Harbor,

There is a PR (#3910) opened to fix it and to be reviewed today, if we can merge it, we fix it and tag 1.3 release.

If we cannot, we can delay it to 1.3.1

pengpengshui added a commit that referenced this issue Jan 4, 2018
Modify skinnable json file and modify images path about #3909 #3879
@pengpengshui
Copy link
Contributor

done

pengpengshui added a commit that referenced this issue Jan 4, 2018
Modify skinnable json file and modify image path about #3909 #3879
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants