Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UAA user see a lot of forbidden error after promoted to admin. #4895

Closed
reasonerjt opened this issue May 9, 2018 · 6 comments
Closed

UAA user see a lot of forbidden error after promoted to admin. #4895

reasonerjt opened this issue May 9, 2018 · 6 comments
Assignees
@reasonerjt
Labels
kind/bug kind/customer-found needs/test-case priority/high product/pks
Milestone
Sprint 34

Comments

@reasonerjt
Copy link
Contributor

Customer found that after login with UAA user, and promote this user to system admin in Harbor. Login with UAA user again he see a lot of forbidden errors on the UI.

root cause
The authenticator of UAA didn't populate all data into the user model in subsequent login of UAA user. And this is not covered in the TC.
@reasonerjt reasonerjt self-assigned this May 9, 2018
@reasonerjt reasonerjt added this to the Sprint 34 milestone May 9, 2018
reasonerjt added a commit to reasonerjt/harbor that referenced this issue May 9, 2018
@reasonerjt
Sync user info after UAA user is logged in
3a34e91 
This is a fix to goharbor#4895.
Currently the user data will not be populated correctly after a user in
UAA is logged in.  This is fixed in this commit.
reasonerjt added a commit to reasonerjt/harbor that referenced this issue May 9, 2018
@reasonerjt
Sync user info after UAA user is logged in
6a607c8 
This is a fix to goharbor#4895.
Currently the user data will not be populated correctly after a user in
UAA is logged in.  This problem is fixed in this commit.
@reasonerjt reasonerjt mentioned this issue May 9, 2018
Merged
reasonerjt added a commit to reasonerjt/harbor that referenced this issue May 9, 2018
@reasonerjt
Sync user info after UAA user is logged in
dd5fe34 
This is a fix to goharbor#4895.
Currently the user data will not be populated correctly after a user in
UAA is logged in.  This problem is fixed in this commit.
reasonerjt added a commit to reasonerjt/harbor that referenced this issue May 10, 2018
@reasonerjt
Sync user info after UAA user is logged in
a9d0dec 
This is a fix to goharbor#4895.
Currently the user data will not be populated correctly after a user in
UAA is logged in.  This problem is fixed in this commit.
reasonerjt added a commit to reasonerjt/harbor that referenced this issue May 10, 2018
@reasonerjt
Sync user info after UAA user is logged in
add3964 
This is a fix to goharbor#4895.
Currently the user data will not be populated correctly after a user in
UAA is logged in.  This problem is fixed in this commit.
jessehu pushed a commit that referenced this issue May 10, 2018
@reasonerjt @jessehu
Sync user info after UAA user is logged in (#4900)
3ca439c 
This is a fix for #4895.
Currently the user's UserId and HasAdminRole data will not be populated correctly after a user in UAA is logged in.
@reasonerjt reasonerjt mentioned this issue May 10, 2018
Merged
@reasonerjt
Copy link
Contributor Author

Fixed in #4900 and cherry picked to 1.4 and 1.5 branch respectively.

@nlowe
Copy link
Contributor

nlowe commented May 11, 2018

@reasonerjt I see a 1.4.1 point release that contains this. Will 1.5 get a point release as well?

@reasonerjt
Copy link
Contributor Author

@nlowe
Yes, but we'll need a couple of more weeks to include other fixes in 1.5.1

Are you using UAA?

@nlowe
Copy link
Contributor

nlowe commented May 11, 2018 •
edited
Loading

@reasonerjt No. is that the only fix in 1.4.1? I'm planning on upgrading to 1.5.0 here in 15ish minutes. If there's nothing else in that patch release I'll just go ahead with the upgrade. A better question would be is there anything major going into 1.5.1 that we should consider skipping 1.5.0?

@reasonerjt
Copy link
Contributor Author

@nlowe
Yes the only fix in 1.4.1 is the UAA bug fix.

There will be a few UI fixes going into 1.5.1 in a addition to the UAA fix. I don't think you have to skip 1.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reasonerjt reasonerjt

Labels
kind/bug kind/customer-found needs/test-case priority/high product/pks
Projects
None yet
Milestone
Sprint 34
Development

No branches or pull requests
3 participants
@nlowe @reasonerjt and others