Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pull update control env #16063

Merged
merged 1 commit into from
Dec 16, 2021

Conversation

wy65701436
Copy link
Contributor

These variables are temporary solution for issue: #16039
When user disable the pull count/time/audit log, it will decrease the database access, especially in large concurrency pull scenarios.

1, PULL_TIME_UPDATE_DISABLE : The flag to indicate if pull time is disable for pull request.
2, PULL_COUNT_UPDATE_DISABLE : The flag to indicate if pull count is disable for pull request.
3, pull audit log will not create on disabling pull time.

Signed-off-by: Wang Yan wangyan@vmware.com

These variables are temporary solution for issue: goharbor#16039
When user disable the pull count/time/audit log, it will decrease the database access, especially in large concurrency pull scenarios.

1, PULL_TIME_UPDATE_DISABLE : The flag to indicate if pull time is disable for pull request.
2, PULL_COUNT_UPDATE_DISABLE : The flag to indicate if pull count is disable for pull request.
3, pull audit log will not create on disabling pull time.

Signed-off-by: Wang Yan <wangyan@vmware.com>
@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #16063 (4849f00) into release-2.4.0 (0395369) will decrease coverage by 0.15%.
The diff coverage is 27.77%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.4.0   #16063      +/-   ##
=================================================
- Coverage          66.83%   66.68%   -0.16%     
=================================================
  Files                933      933              
  Lines              77716    77323     -393     
  Branches            2287     2287              
=================================================
- Hits               51944    51559     -385     
+ Misses             21768    21758      -10     
- Partials            4004     4006       +2     
Flag Coverage Δ
unittests 66.68% <27.77%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/controller/event/handler/internal/artifact.go 0.00% <0.00%> (ø)
src/lib/config/userconfig.go 73.91% <0.00%> (-1.98%) ⬇️
src/controller/event/handler/auditlog/auditlog.go 56.52% <45.45%> (+0.96%) ⬆️
src/common/rbac/system/namespace.go 33.33% <0.00%> (-11.12%) ⬇️
src/controller/event/topic.go 9.00% <0.00%> (-1.81%) ⬇️
src/server/v2.0/restapi/embedded_spec.go 100.00% <0.00%> (ø)
.../src/app/base/left-side-nav/user/user.component.ts 18.47% <0.00%> (+0.63%) ⬆️
src/chartserver/cache.go 53.16% <0.00%> (+0.92%) ⬆️
...tegration/tag-retention/tag-retention.component.ts 32.15% <0.00%> (+2.20%) ⬆️
...es/vulnerability/vulnerability-config.component.ts 55.55% <0.00%> (+4.76%) ⬆️
... and 2 more

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@wy65701436 wy65701436 merged commit 2e6650a into goharbor:release-2.4.0 Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants