Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UI with more inclusive words #16548

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

AllForNothing
Copy link
Contributor

Signed-off-by: AllForNothing sshijun@vmware.com

Signed-off-by: AllForNothing <sshijun@vmware.com>
@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #16548 (6a2e653) into main (c54f51d) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16548      +/-   ##
==========================================
+ Coverage   67.39%   67.40%   +0.01%     
==========================================
  Files         951      951              
  Lines       78924    78924              
  Branches     2322     2322              
==========================================
+ Hits        53190    53200      +10     
+ Misses      22171    22161      -10     
  Partials     3563     3563              
Flag Coverage Δ
unittests 67.40% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/controller/event/topic.go 10.81% <0.00%> (+9.00%) ⬆️

Copy link
Member

@OrlinVasilev OrlinVasilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AllForNothing AllForNothing merged commit 33da8e2 into goharbor:main Mar 22, 2022
@AllForNothing AllForNothing deleted the inclusive branch March 25, 2022 03:57
sluetze pushed a commit to sluetze/harbor that referenced this pull request Oct 29, 2022
Signed-off-by: AllForNothing <sshijun@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants