Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve css for accessories component #16868

Merged
merged 1 commit into from
May 18, 2022

Conversation

AllForNothing
Copy link
Contributor

  1. Improve css for accessories component
    before:

image

after:
image

Signed-off-by: AllForNothing sshijun@vmware.com

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@AllForNothing AllForNothing requested a review from a team as a code owner May 17, 2022 08:28
@AllForNothing AllForNothing self-assigned this May 17, 2022
@AllForNothing AllForNothing added release-note/enhancement Label to mark PR to be added under release notes as enhancement target/2.6.0 labels May 17, 2022
@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #16868 (2983cd4) into main (2852a76) will decrease coverage by 0.00%.
The diff coverage is 62.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16868      +/-   ##
==========================================
- Coverage   67.21%   67.21%   -0.01%     
==========================================
  Files         966      966              
  Lines       80122    80133      +11     
  Branches     2546     2548       +2     
==========================================
+ Hits        53855    53862       +7     
- Misses      22595    22600       +5     
+ Partials     3672     3671       -1     
Flag Coverage Δ
unittests 67.21% <62.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t-tab/sub-accessories/sub-accessories.component.ts 73.91% <62.50%> (-0.45%) ⬇️
...-nav/gc-page/gc/gc-history/gc-history.component.ts 51.85% <0.00%> (-9.26%) ⬇️
src/common/utils/passports.go 84.61% <0.00%> (-5.13%) ⬇️
...nerabilities/artifact-vulnerabilities.component.ts 58.59% <0.00%> (-1.88%) ⬇️
src/server/v2.0/handler/artifact.go 9.80% <0.00%> (-0.08%) ⬇️
src/controller/event/topic.go 10.81% <0.00%> (+1.80%) ⬆️
src/pkg/accessory/dao/dao.go 68.62% <0.00%> (+1.96%) ⬆️
src/controller/event/handler/auditlog/auditlog.go 60.86% <0.00%> (+4.34%) ⬆️
src/core/api/internal.go 53.33% <0.00%> (+13.33%) ⬆️

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: AllForNothing <sshijun@vmware.com>
@AllForNothing AllForNothing merged commit 5a4f6c6 into goharbor:main May 18, 2022
@AllForNothing AllForNothing deleted the cosign-css branch July 25, 2022 02:58
sluetze pushed a commit to sluetze/harbor that referenced this pull request Oct 29, 2022
Signed-off-by: AllForNothing <sshijun@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/enhancement Label to mark PR to be added under release notes as enhancement target/2.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants