Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump up golang version to v1.18.3 #16957

Merged
merged 1 commit into from
Jun 8, 2022
Merged

bump up golang version to v1.18.3 #16957

merged 1 commit into from
Jun 8, 2022

Conversation

MinerYang
Copy link
Contributor

Signed-off-by: yminer yminer@vmware.com

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@MinerYang MinerYang added the release-note/update Update or Fix label Jun 7, 2022
@MinerYang MinerYang requested a review from a team as a code owner June 7, 2022 08:17
@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #16957 (8afaf71) into main (9b22e29) will decrease coverage by 0.04%.
The diff coverage is n/a.

❗ Current head 8afaf71 differs from pull request most recent head 53f562e. Consider uploading reports for the commit 53f562e to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16957      +/-   ##
==========================================
- Coverage   67.25%   67.21%   -0.05%     
==========================================
  Files         974      974              
  Lines       81479    81479              
  Branches     2599     2599              
==========================================
- Hits        54800    54766      -34     
- Misses      22956    22992      +36     
+ Partials     3723     3721       -2     
Flag Coverage Δ
unittests 67.21% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...g-retention-tasks/tag-retention-tasks.component.ts 61.11% <0.00%> (-25.00%) ⬇️
...audit-log-purge/history/purge-history.component.ts 49.01% <0.00%> (-9.81%) ⬇️
...tegration/tag-retention/tag-retention.component.ts 30.90% <0.00%> (-5.16%) ⬇️
src/common/utils/passports.go 84.61% <0.00%> (-5.13%) ⬇️
...es/vulnerability/vulnerability-config.component.ts 58.51% <0.00%> (-4.45%) ⬇️
src/controller/event/handler/auditlog/auditlog.go 56.52% <0.00%> (-4.35%) ⬇️
src/controller/event/topic.go 9.00% <0.00%> (-1.81%) ⬇️
src/jobservice/period/enqueuer.go 63.93% <0.00%> (-0.82%) ⬇️
src/jobservice/worker/cworker/c_worker.go 68.42% <0.00%> (+1.91%) ⬆️

Signed-off-by: yminer <yminer@vmware.com>

update ci/ut_install.sh

Signed-off-by: yminer <yminer@vmware.com>
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MinerYang MinerYang merged commit b8a71ac into goharbor:main Jun 8, 2022
sluetze pushed a commit to sluetze/harbor that referenced this pull request Oct 29, 2022
Signed-off-by: yminer <yminer@vmware.com>

update ci/ut_install.sh

Signed-off-by: yminer <yminer@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants