Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] Fix scan log mismatch issue #17241

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

wy65701436
Copy link
Contributor

@wy65701436 wy65701436 commented Jul 25, 2022

1, add check in label
2, check robot account update
3, validate scan log

Signed-off-by: Wang Yan wangyan@vmware.com

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

1, add check in label
2, check robot account update
3, validate scan log

Signed-off-by: Wang Yan <wangyan@vmware.com>
@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #17241 (5ff077f) into release-2.4.0 (b3aad82) will decrease coverage by 0.05%.
The diff coverage is 17.02%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.4.0   #17241      +/-   ##
=================================================
- Coverage          66.66%   66.60%   -0.06%     
=================================================
  Files                934      934              
  Lines              77363    77399      +36     
  Branches            2287     2287              
=================================================
- Hits               51571    51555      -16     
- Misses             21781    21828      +47     
- Partials            4011     4016       +5     
Flag Coverage Δ
unittests 66.60% <17.02%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/rbac/project/rbac_role.go 66.66% <ø> (ø)
src/controller/scan/controller.go 100.00% <ø> (ø)
src/core/api/chart_label.go 79.54% <0.00%> (-3.79%) ⬇️
src/server/v2.0/handler/artifact.go 10.68% <0.00%> (-0.58%) ⬇️
src/server/v2.0/handler/robot.go 3.76% <0.00%> (-0.11%) ⬇️
src/server/v2.0/handler/scan.go 18.42% <0.00%> (ø)
src/controller/scan/base_controller.go 61.43% <44.44%> (-0.66%) ⬇️
src/lib/cache/util.go 73.68% <0.00%> (-15.79%) ⬇️
src/core/api/internal.go 40.00% <0.00%> (-13.34%) ⬇️
...es/vulnerability/vulnerability-config.component.ts 46.82% <0.00%> (-8.74%) ⬇️
... and 4 more

@wy65701436 wy65701436 changed the title Fix scan log mismatch issue [cherry-pick] Fix scan log mismatch issue Jul 26, 2022
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit 9cbdb8c into goharbor:release-2.4.0 Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants