Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Publish to Github Packages #18180

Merged
merged 2 commits into from
Mar 13, 2023
Merged

Fixes Publish to Github Packages #18180

merged 2 commits into from
Mar 13, 2023

Conversation

Nageshbansal
Copy link
Contributor

@Nageshbansal Nageshbansal commented Feb 6, 2023 •
edited
Loading

  1. Creates a publishPackages function in tools/release/release_utils.sh
  2. Uses the publishPackages function in publish_release workflow

Fixes issue #18138

Signed-off-by: Nagesh Bansal nageshbansal59@gmail.com

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@Nageshbansal Nageshbansal requested a review from a team as a code owner February 6, 2023 22:21
@Nageshbansal
Copy link
Contributor Author

@YangJiao0817 can you please review it?

@OrlinVasilev
Copy link
Member

@Nageshbansal are you sure it fixes issue #18186 ??

@Nageshbansal
Copy link
Contributor Author

Nageshbansal commented Feb 7, 2023 •
edited
Loading

I think the PR description mentioned the wrong issue.
This PR is for issue #18138 and For this issue the future releases, the harbor will be able to push images to github packages. But for the images after v2.6.2, I think we have to push them separately.

@OrlinVasilev
Copy link
Member

the mentioned issue and your code do not represent the same issue

@Nageshbansal
Copy link
Contributor Author

yeah sorry for that, i just updated the mentioned issue.

@OrlinVasilev
Copy link
Member

I think that should go over proposal discussion for changing the release process @goharbor/all-maintainers thoughts?

@Nageshbansal
Copy link
Contributor Author

hey, @OrlinVasilev any updates on this?

@codecov
Copy link

codecov bot commented Feb 20, 2023 •
edited
Loading

Codecov Report

Merging #18180 (d6b179f) into main (9b61d34) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #18180   +/-   ##
=======================================
  Coverage   67.47%   67.47%           
=======================================
  Files         971      971           
  Lines      106223   106223           
  Branches     2649     2649           
=======================================
+ Hits        71670    71671    +1     
+ Misses      30717    30712    -5     
- Partials     3836     3840    +4
Flag Coverage Δ
unittests 67.47% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

@YangJiao0817 YangJiao0817 added release-note/infra Infra related changes e.g. release, test, ship etc... area/ci labels Feb 23, 2023
YangJiao0817
YangJiao0817 requested changes Feb 28, 2023
View reviewed changes
.github/workflows/publish_release.yml Outdated Show resolved Hide resolved
tools/release/release_utils.sh Outdated Show resolved Hide resolved
@Nageshbansal
Fixes Publish to Github Packages
b8c1e3e 
1. Creates a publishPackages function in tools/release/release_utils.sh
2. Uses the publishPackages function in publish_release workflow

Fixes issue 18138

Signed-off-by: Nagesh Bansal <nageshbansal59@gmail.com>
wy65701436
wy65701436 approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YangJiao0817 YangJiao0817 merged commit 125daf9 into goharbor:main Mar 13, 2023
@OrlinVasilev
Copy link
Member

@Nageshbansal congratulations on your first PR merged :)) Welcome to the club :)

@Nageshbansal
Copy link
Contributor Author

Thanks @OrlinVasilev @YangJiao0817 @wy65701436 . And I'm eager to tackle more issues and contribute further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wy65701436 wy65701436 wy65701436 approved these changes

@YangJiao0817 YangJiao0817 YangJiao0817 approved these changes

Assignees

@zyyw zyyw

@OrlinVasilev OrlinVasilev

@MinerYang MinerYang

Labels
area/ci release-note/infra Infra related changes e.g. release, test, ship etc...
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Nageshbansal @OrlinVasilev @wy65701436 @YangJiao0817 @zyyw @MinerYang