Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add referrers api #18324

Merged
merged 2 commits into from
Mar 12, 2023
Merged

add referrers api #18324

merged 2 commits into from
Mar 12, 2023

Conversation

wy65701436
Copy link
Contributor

@wy65701436 wy65701436 commented Mar 9, 2023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #18324 (a7a58e7) into main (ab636fe) will increase coverage by 0.00%.
The diff coverage is 58.49%.

Impacted file tree graph

@@           Coverage Diff            @@
##             main   #18324    +/-   ##
========================================
  Coverage   67.47%   67.47%            
========================================
  Files         970      971     +1     
  Lines      106117   106223   +106     
  Branches     2649     2649            
========================================
+ Hits        71600    71674    +74     
- Misses      30690    30712    +22     
- Partials     3827     3837    +10     
Flag Coverage Δ
unittests 67.47% <58.49%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/lib/patterns.go 100.00% <ø> (ø)
...rc/server/middleware/artifactinfo/artifact_info.go 85.71% <ø> (ø)
src/server/middleware/metric/metric.go 0.00% <ø> (ø)
src/server/registry/route.go 0.00% <0.00%> (ø)
src/server/registry/referrers.go 61.38% <61.38%> (ø)

... and 7 files with indirect coverage changes

@wy65701436 wy65701436 added the release-note/new-feature New Harbor Feature label Mar 9, 2023
@wy65701436 wy65701436 force-pushed the referrers branch 3 times, most recently from cbff5cd to 846d61c Compare March 10, 2023 03:53
Copy link
Contributor

@stonezdj stonezdj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

The define of referrers api in the upstream oci spec: https://github.com/opencontainers/distribution-spec/blob/v1.1.0-rc1/spec.md#listing-referrers

Signed-off-by: Wang Yan <wangyan@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants