Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix incorrect otel timeout in harbor yaml template #19120

Merged
merged 1 commit into from Aug 16, 2023

Conversation

chlins
Copy link
Member

@chlins chlins commented Aug 8, 2023

Update the incorrect otel timeout sample value in the harbor YAML configuration template.

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #19084

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@chlins chlins requested a review from a team as a code owner August 8, 2023 02:05
@chlins chlins added the release-note/update Update or Fix label Aug 8, 2023
Copy link
Contributor

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #19120 (98b38d4) into main (289d4e2) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19120      +/-   ##
==========================================
- Coverage   67.42%   67.39%   -0.03%     
==========================================
  Files         993      993              
  Lines      108864   108864              
  Branches     2751     2751              
==========================================
- Hits        73397    73369      -28     
- Misses      31522    31549      +27     
- Partials     3945     3946       +1     
Flag Coverage Δ
unittests 67.39% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

@chlins chlins force-pushed the chore/harbor-yaml-otel branch 2 times, most recently from 5a87f90 to c150215 Compare August 8, 2023 02:30
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins force-pushed the chore/harbor-yaml-otel branch 2 times, most recently from 2e75adb to 09d5aa9 Compare August 16, 2023 01:04
Update the incorrect otel timeout sample value in the harbor YAML
configuration template.

Signed-off-by: chlins <chenyuzh@vmware.com>
@chlins chlins merged commit 56f6c27 into goharbor:main Aug 16, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Otel failed to send traces
5 participants