Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove job status track information from redis after stop #19227

Merged
merged 1 commit into from Sep 5, 2023

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Aug 22, 2023

fixes #19211

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner August 22, 2023 01:34
@stonezdj stonezdj added the release-note/update Update or Fix label Aug 22, 2023
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #19227 (87d2655) into main (e2d0889) will increase coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 52.38%.

❗ Current head 87d2655 differs from pull request most recent head 8636041. Consider uploading reports for the commit 8636041 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19227      +/-   ##
==========================================
+ Coverage   67.39%   67.40%   +0.01%     
==========================================
  Files         993      993              
  Lines      108898   108917      +19     
  Branches     2752     2751       -1     
==========================================
+ Hits        73389    73416      +27     
+ Misses      31565    31557       -8     
  Partials     3944     3944              
Flag Coverage Δ
unittests 67.40% <52.38%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/pkg/jobmonitor/redis.go 17.58% <52.38%> (+17.58%) ⬆️

... and 9 files with indirect coverage changes

src/pkg/jobmonitor/redis.go Outdated Show resolved Hide resolved
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

…the queue

  After stop in the queue:
  Remove key in {harbor_job_service_namespace}:job_track:inprogress
  Remove {harbor_job_service_namespace}:job_stats:<job_id>
  fixes goharbor#19211

Signed-off-by: stonezdj <daojunz@vmware.com>
@stonezdj stonezdj merged commit 7f19163 into goharbor:main Sep 5, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop job queue remains obsolete job keys
4 participants