Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo in ROADMAP.md #19247

Merged
merged 1 commit into from
Aug 28, 2023
Merged

fix typo in ROADMAP.md #19247

merged 1 commit into from
Aug 28, 2023

Conversation

liubin
Copy link
Contributor

@liubin liubin commented Aug 28, 2023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

fix typo in ROADMAP.md

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@liubin liubin requested a review from a team as a code owner August 28, 2023 03:18
AllForNothing
AllForNothing approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@AllForNothing AllForNothing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AllForNothing AllForNothing added the release-note/update Update or Fix label Aug 28, 2023
@liubin @AllForNothing
fix typo in ROADMAP.md
91df526 
Signed-off-by: bin liu <liubin0329@gmail.com>
chlins
chlins approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AllForNothing AllForNothing merged commit 39f3230 into goharbor:main Aug 28, 2023
10 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AllForNothing AllForNothing AllForNothing approved these changes

@chlins chlins chlins approved these changes

Assignees

@stonezdj stonezdj

@zyyw zyyw

@chlins chlins

Labels
release-note/update Update or Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@liubin @AllForNothing @chlins @stonezdj @zyyw