Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix storage.redirect.disable migrate template error #19335

Merged
merged 2 commits into from Sep 12, 2023

Conversation

MinerYang
Copy link
Contributor

@MinerYang MinerYang commented Sep 11, 2023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #19320

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: yminer <yminer@vmware.com>

update boolean to lowercase
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #19335 (c51bf75) into main (d55823d) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19335      +/-   ##
==========================================
- Coverage   44.93%   44.90%   -0.03%     
==========================================
  Files         244      244              
  Lines       13416    13416              
  Branches     2752     2752              
==========================================
- Hits         6028     6025       -3     
- Misses       7083     7086       +3     
  Partials      305      305              
Flag Coverage Δ
unittests 44.90% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@MinerYang MinerYang assigned YangJiao0817 and unassigned Vad1mo Sep 11, 2023
@MinerYang MinerYang enabled auto-merge (squash) September 12, 2023 03:16
@MinerYang MinerYang merged commit eb0724d into goharbor:main Sep 12, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

harbor v2.9.0 migration error, jinja template typo/bug
6 participants