Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid menu closure when filtering labels #19561

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Nov 10, 2023

  1. Fixes Cannot filter labels #19554

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #19561 (32fa28a) into main (30730c6) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19561      +/-   ##
==========================================
+ Coverage   45.24%   45.33%   +0.08%     
==========================================
  Files         244      244              
  Lines       13323    13324       +1     
  Branches     2720     2720              
==========================================
+ Hits         6028     6040      +12     
+ Misses       6993     6984       -9     
+ Partials      302      300       -2     
Flag Coverage Δ
unittests 45.33% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ponents/label-selector/label-selector.component.ts 68.18% <100.00%> (+0.48%) ⬆️

... and 3 files with indirect coverage changes

1. Fixes goharbor#19554

Signed-off-by: AllForNothing <sshijun@vmware.com>
@AllForNothing AllForNothing merged commit da9e263 into goharbor:main Nov 15, 2023
12 checks passed
altynbaev pushed a commit to altynbaev/harbor that referenced this pull request Jan 29, 2024
1. Fixes goharbor#19554

Signed-off-by: AllForNothing <sshijun@vmware.com>
Signed-off-by: Altynbaev Dinislam <altynbayevdr@sberautotech.ru>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot filter labels
6 participants