Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick]fix label select bugs (#19850) #19861

Merged
merged 1 commit into from Jan 19, 2024

Conversation

YangJiao0817
Copy link
Member

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #19850

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9091d39) 67.42% compared to head (52d7396) 44.82%.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-2.9.0   #19861       +/-   ##
==================================================
- Coverage          67.42%   44.82%   -22.61%     
==================================================
  Files                993      244      -749     
  Lines             108937    13417    -95520     
  Branches            2752     2752               
==================================================
- Hits               73452     6014    -67438     
+ Misses             31530     7097    -24433     
+ Partials            3955      306     -3649     
Flag Coverage Δ
unittests 44.82% <50.00%> (-22.61%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ion/create-edit-rule/create-edit-rule.component.ts 35.71% <50.00%> (+0.18%) ⬆️

... and 752 files with indirect coverage changes

@YangJiao0817 YangJiao0817 requested review from MinerYang and removed request for stonezdj January 19, 2024 06:13
@zyyw
Copy link
Contributor

zyyw commented Jan 19, 2024

@YangJiao0817 Please label with a release version of this PR.

Signed-off-by: shengqiw <shengqiw@vmware.com>
@YangJiao0817 YangJiao0817 enabled auto-merge (squash) January 19, 2024 07:14
@YangJiao0817 YangJiao0817 merged commit 58892ae into goharbor:release-2.9.0 Jan 19, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants