Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reverse ip_family config for release-2.9 #19951

Merged
merged 1 commit into from Feb 6, 2024
Merged

reverse ip_family config for release-2.9 #19951

merged 1 commit into from Feb 6, 2024

Conversation

MinerYang
Copy link
Contributor

@MinerYang MinerYang commented Feb 5, 2024 •
edited

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

#19932 (comment)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@MinerYang
reverse ip_family config for release-2.9
ac8d3b5 
Signed-off-by: yminer <yminer@vmware.com>
@MinerYang MinerYang added the release-note/update Update or Fix label Feb 5, 2024
@MinerYang MinerYang requested a review from a team as a code owner February 5, 2024 09:52
@MinerYang MinerYang mentioned this pull request Feb 5, 2024
Closed
wy65701436
wy65701436 approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit dfb317b into goharbor:release-2.9.0 Feb 6, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stonezdj stonezdj stonezdj approved these changes

@wy65701436 wy65701436 wy65701436 approved these changes

Assignees

@stonezdj stonezdj

@wy65701436 wy65701436

@zyyw zyyw

@AllForNothing AllForNothing

@chlins chlins

Labels
release-note/update Update or Fix target/2.9.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@MinerYang @stonezdj @wy65701436 @zyyw @AllForNothing @chlins