Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add menu item for ko_KR local #20602

Merged
merged 3 commits into from
Jun 17, 2024
Merged

Conversation

stonezdj
Copy link
Contributor

fixes #20600

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

  fixes goharbor#20600

Signed-off-by: stonezdj <stone.zhang@broadcom.com>
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.29%. Comparing base (b7b8847) to head (08e1d16).
Report is 223 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #20602       +/-   ##
===========================================
- Coverage   67.56%   46.29%   -21.28%     
===========================================
  Files         991      247      -744     
  Lines      109181    13777    -95404     
  Branches     2719     2845      +126     
===========================================
- Hits        73768     6378    -67390     
+ Misses      31449     7069    -24380     
+ Partials     3964      330     -3634     
Flag Coverage Δ
unittests 46.29% <ø> (-21.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1238 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zyyw zyyw enabled auto-merge (squash) June 17, 2024 11:11
@zyyw zyyw merged commit 02b3561 into goharbor:main Jun 17, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Korean language translation cannot selected in the UI
7 participants