Fix issue about endpoint test connection #3661 #3672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steven-zou
requested changes
Nov 28, 2017
steven-zou
requested changes
Nov 29, 2017
|
|
||
| //private | ||
| compareValue(a: any, b: any): boolean { |
There was a problem hiding this comment.
Use functions in the utils.js
| if (!(this.targetNameHasChanged || this.endpointHasChanged || this.checkboxHasChanged)) { | ||
| return;//Avoid invalid submitting | ||
| } | ||
|
|
||
| let payload: Endpoint = this.initEndpoint(); |
There was a problem hiding this comment.
let payload = this.getChanges()
There was a problem hiding this comment.
add '[key: string]: any | any[]' to endpoint interface
| </div> | ||
| <div class="form-group"> | ||
| <label for="destination_password" class="col-md-4 form-group-label-override">{{ 'DESTINATION.PASSWORD' | translate }}</label> | ||
| <input type="password" class="col-md-8" id="destination_password" [disabled]="testOngoing" [readonly]="!editable" [(ngModel)]="target.password" size="20" name="password" #password="ngModel" (focus)="clearPassword($event)"> | ||
| <input type="password" class="col-md-8" id="destination_password" [disabled]="testOngoing" [readonly]="!editable" [(ngModel)]="target.password" size="20" name="password" #password="ngModel"> |
There was a problem hiding this comment.
use inProgress to replace testOngoing || Ongoing
pengpengshui
force-pushed
the
ping_endpoint
branch
from
f22ebee
to
5f93735
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue about test connection with wrong password in endpoint
Fix bug about inline alert undisappear