Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update user_guide about the build history. #6495

Merged
merged 1 commit into from
Dec 19, 2018
Merged

update user_guide about the build history. #6495

merged 1 commit into from
Dec 19, 2018

Conversation

kofj
Copy link
Contributor

@kofj kofj commented Dec 10, 2018

Signed-off-by: Frank Kung kfanjian@gmail.com

@coveralls
Copy link

coveralls commented Dec 10, 2018

Pull Request Test Coverage Report for Build 10004

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 65.305%

Files with Coverage Reduction New Missed Lines %
src/core/api/repository.go 3 41.66%
Totals Coverage Status
Change from base Build 10003: -0.01%
Covered Lines: 13426
Relevant Lines: 20559

💛 - Coveralls

@kofj kofj mentioned this pull request Dec 10, 2018
@ywk253100 ywk253100 added the target/1.7.0 Work items that should be delivered in 1.7.0 timeframe. label Dec 12, 2018
ghost
ghost previously requested changes Dec 12, 2018
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit, else lgtm


Have you ever found an image on Harbor and wondered what code it was built from? Or tried to locate the image for a source code repository? Build history make it easy to see the contents of a container image.

In harbor portal, enter your project, select the repository, click on the link of tag name you'd like to see its build history, the detail page will be opened. Then switch to `Build History` tab, you can see the build history information.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: s/harbor/Harbor

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix

Copy link
Contributor

@steven-zou steven-zou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do change

@@ -589,3 +590,10 @@ If you are a system admin, you can view the latest 10 records of garbage collect
You can click on the 'details' link to view the related logs.
![browse project](img/gc_details.png)

## Build history

Have you ever found an image on Harbor and wondered what code it was built from? Or tried to locate the image for a source code repository? Build history make it easy to see the contents of a container image.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need an interrogative sentence here. Just directly describe what build history can do.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll rewrite later.

Signed-off-by: Frank Kung <kfanjian@gmail.com>
Copy link
Contributor

@steven-zou steven-zou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-zou steven-zou dismissed ghost ’s stale review December 19, 2018 02:57

The issue mentioned in the comments is fixed.

@steven-zou steven-zou merged commit 007a374 into goharbor:master Dec 19, 2018
wy65701436 pushed a commit that referenced this pull request Dec 19, 2018
[Cherry-Pick] update user_guide about the build history.

Signed-off-by: Frank Kung <kfanjian@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
target/1.7.0 Work items that should be delivered in 1.7.0 timeframe.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants