Skip to content

Commit

Permalink
Fix lazy publishing with publishResources=false
Browse files Browse the repository at this point in the history
Fixes #6914
  • Loading branch information
bep committed Feb 19, 2020
1 parent dce210a commit 9bdedb2
Show file tree
Hide file tree
Showing 3 changed files with 34 additions and 1 deletion.
1 change: 1 addition & 0 deletions hugolib/content_map_page.go
Expand Up @@ -262,6 +262,7 @@ func (m *pageMap) newResource(fim hugofs.FileMetaInfo, owner *pageState) (resour
FileInfo: fim,
RelTargetFilename: target,
TargetBasePaths: targetBasePaths,
LazyPublish: !owner.m.buildConfig.PublishResources,
})
}

Expand Down
30 changes: 30 additions & 0 deletions hugolib/disableKinds_test.go
Expand Up @@ -32,6 +32,7 @@ disableKinds = [%q]
`, disableKind)

b := newTestSitesBuilder(c)
b.WithTemplatesAdded("_default/single.html", `single`)
b.WithConfigFile("toml", config).WithContent("sect/page.md", `
---
title: Page
Expand Down Expand Up @@ -281,3 +282,32 @@ home = [ "HTML", "RSS" ]
b.Assert(b.CheckExists("public/index.xml"), qt.Equals, false)

}

func TestBundleNoPublishResources(t *testing.T) {
b := newTestSitesBuilder(t)
b.WithTemplates("index.html", `
{{ $bundle := site.GetPage "section/bundle-false" }}
{{ $data1 := $bundle.Resources.GetMatch "data1*" }}
Data1: {{ $data1.RelPermalink }}
`)

b.WithContent("section/bundle-false/index.md", `---\ntitle: BundleFalse
_build:
publishResources: false
---`,
"section/bundle-false/data1.json", "Some data1",
"section/bundle-false/data2.json", "Some data2",
)

b.WithContent("section/bundle-true/index.md", `---\ntitle: BundleTrue
---`,
"section/bundle-true/data3.json", "Some data 3",
)

b.Build(BuildCfg{})
b.AssertFileContent("public/index.html", `Data1: /section/bundle-false/data1.json`)
b.AssertFileContent("public/section/bundle-false/data1.json", `Some data1`)
b.Assert(b.CheckExists("public/section/bundle-false/data2.json"), qt.Equals, false)
b.AssertFileContent("public/section/bundle-true/data3.json", `Some data 3`)
}
4 changes: 3 additions & 1 deletion hugolib/page.go
Expand Up @@ -258,7 +258,9 @@ func (p *pageState) sortResources() {
return page.DefaultPageSort(p1, p2)
}

return ri.RelPermalink() < rj.RelPermalink()
// Make sure not to use RelPermalink or any of the other methods that
// trigger lazy publishing.
return ri.Name() < rj.Name()
})
}

Expand Down

0 comments on commit 9bdedb2

Please sign in to comment.