Permalink
Browse files

Render task list item inside label for correct accessibility

Fixes #3303
  • Loading branch information...
danieka authored and bep committed Aug 4, 2017
1 parent 0abdeee commit c8257f8b726478ca70dc8984cdcc17b31e4bdc0c
Showing with 8 additions and 6 deletions.
  1. +4 −2 helpers/content_renderer.go
  2. +4 −4 helpers/content_renderer_test.go
@@ -50,10 +50,12 @@ func (r *HugoHTMLRenderer) ListItem(out *bytes.Buffer, text []byte, flags int) {
switch {
case bytes.HasPrefix(text, []byte("[ ] ")):
text = append([]byte(`<input type="checkbox" disabled class="task-list-item">`), text[3:]...)
text = append([]byte(`<label><input type="checkbox" disabled class="task-list-item">`), text[3:]...)
text = append(text, []byte(`</label>`)...)
case bytes.HasPrefix(text, []byte("[x] ")) || bytes.HasPrefix(text, []byte("[X] ")):
text = append([]byte(`<input type="checkbox" checked disabled class="task-list-item">`), text[3:]...)
text = append([]byte(`<label><input type="checkbox" checked disabled class="task-list-item">`), text[3:]...)
text = append(text, []byte(`</label>`)...)
}
r.Renderer.ListItem(out, text, flags)
@@ -108,9 +108,9 @@ END
`, true, `<p>TODO:</p>
<ul class="task-list">
<li><input type="checkbox" checked disabled class="task-list-item"> On1</li>
<li><input type="checkbox" checked disabled class="task-list-item"> On2</li>
<li><input type="checkbox" disabled class="task-list-item"> Off</li>
<li><label><input type="checkbox" checked disabled class="task-list-item"> On1</label></li>
<li><label><input type="checkbox" checked disabled class="task-list-item"> On2</label></li>
<li><label><input type="checkbox" disabled class="task-list-item"> Off</label></li>
</ul>
<p>END</p>
@@ -122,7 +122,7 @@ END
{`* [ ] Off
END`, true, `<ul class="task-list">
<li><input type="checkbox" disabled class="task-list-item"> Off</li>
<li><label><input type="checkbox" disabled class="task-list-item"> Off</label></li>
</ul>
<p>END</p>

0 comments on commit c8257f8

Please sign in to comment.